feat: add ai-navigator-app #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/M
|
This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md |
Pull Request Test Coverage Report for Build 6023072203
💛 - Coveralls |
cbuto
reviewed
Aug 31, 2023
github-actions
bot
added
size/L
mstruebing
force-pushed
the
mstruebing/feat/D2IQ-98636-ai-navigator-app
branch
from
4168b79 to
ab1b448
Compare
github-actions
bot
removed
size/L
mstruebing
force-pushed
the
mstruebing/feat/D2IQ-98636-ai-navigator-app
branch
from
1bd1688 to
e9e2f41
Compare
github-actions
bot
added
size/L
mikolajb
reviewed
Sep 4, 2023
2 tasks
mstruebing
force-pushed
the
mstruebing/feat/D2IQ-98636-ai-navigator-app
branch
from
420cec0 to
63bbca5
Compare
mstruebing
force-pushed
the
mstruebing/feat/D2IQ-98636-ai-navigator-app
branch
from
e50743a to
730ae56
Compare
mstruebing
added
ready-for-review
ok-to-test
mstruebing
force-pushed
the
mstruebing/feat/D2IQ-98636-ai-navigator-app
branch
from
56b08bf to
f581ab6
Compare
nataliepina
reviewed
Sep 7, 2023
mikolajb
approved these changes
Sep 7, 2023
nataliepina
approved these changes
Sep 7, 2023
cbuto
approved these changes
Sep 7, 2023
I've created them yesterday 😇 |
|
@mstruebing can we backport this to 2.6 as-is? |
|
@cbuto yes we can! :) |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
|
@mstruebing looks like we'll have to manually create the backport by cherry-picking the commit(s) 😞 |
mstruebing
added a commit
that referenced
this pull request
Sep 11, 2023
* feat: add ai-navigator-app
* Closes D2IQ-98636
* chore: use `${releaseNamespace}` instead of hardcoded namespace
* chore: allow to read licenses and secrets
* chore: allow to read licenses and secrets
* chore: add liveness and readiness probes
* chore: update description
* feat: specifiy security context
* chore: use correct logo
* chore: indent securityContext
* chore: add period
* chore: use correct version
mstruebing
added a commit
that referenced
this pull request
Sep 11, 2023
* feat: Introduce empty kustomization of ai-navigation-app (#1547) * feat: Introduce empty kustomization of ai-navigation-app Signed-off-by: Mikołaj Baranowski <[email protected]> * build: Updated .github/service-labeler.yaml --------- Signed-off-by: Mikołaj Baranowski <[email protected]> Co-authored-by: d2iq-mergebot <[email protected]> * feat: add ai-navigator-app (#1514) * feat: add ai-navigator-app * Closes D2IQ-98636 * chore: use `${releaseNamespace}` instead of hardcoded namespace * chore: allow to read licenses and secrets * chore: allow to read licenses and secrets * chore: add liveness and readiness probes * chore: update description * feat: specifiy security context * chore: use correct logo * chore: indent securityContext * chore: add period * chore: use correct version --------- Signed-off-by: Mikołaj Baranowski <[email protected]> Co-authored-by: Mikołaj Baranowski <[email protected]> Co-authored-by: d2iq-mergebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
This PR adds the ai-navitgator-app to our
kommander-applicationscatalog.Which issue(s) does this PR fix?:
https://d2iq.atlassian.net/browse/D2IQ-98636
Special notes for your reviewer:
This PR is a WIP.We need to change the description and the icon.I've applied these resources to the daily and get:What do I need to do so that the service would be able to read licenses and the corresponding secret?Also, is it okay to hardcode the namespace tokommander? (this application should always be deployed in this namespace)Should I split these resources into multiple files or is it okay to have them in one?I think this needs to be merged into the 2.6 branch to be available in 2.6.1.
I'm not sure how commit messages come into play here, but should I change it to
fix?Is there a way to apply the catalog from this branch on a cluster? Right now I simply applied theDeploymentandServicedefinition, but for a real test I would like to use it like it would be used in reality.Does this PR introduce a user-facing change?:
Checklist