Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to kubecost v2 #2959

Merged
merged 11 commits into from
Jan 8, 2025
Merged

feat: upgrade to kubecost v2 #2959

merged 11 commits into from
Jan 8, 2025

Conversation

takirala
Copy link
Contributor

@takirala takirala commented Dec 18, 2024 •
edited
Loading

What problem does this PR solve?:

Upgrade kubecost to v2.

From 2.14.x, we no longer need centralized-kubecost as there is no need to run multiple instance of kubecost on management cluster. We will have just one kubecost service which is controlled via the valuesFrom field of kubecost HelmRelease. I have added comments where needed and there are some TODO's left in the code that will be follow up PRs.

Which issue(s) does this PR fix?:

NCN-104266
NCN-104267

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@github-actions github-actions bot added services/centralized-kubecost services/kubecost size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 18, 2024
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo update-licenses signals mergebot to update licenses.d2iq.yaml labels Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/tga/kubecost-v2

@coveralls
Copy link

coveralls commented Dec 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12661230226

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%
Totals Coverage Status
Change from base Build 12638581195: 0.0%
Covered Lines: 167
Relevant Lines: 323
💛 - Coveralls

@takirala takirala removed do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo labels Dec 26, 2024
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo labels Dec 31, 2024
@takirala takirala removed the open-kommander-pr Automatically triggers the creation of a PR in Kommander repo label Dec 31, 2024
@mesosphere-ci mesosphere-ci added the open-kommander-pr Automatically triggers the creation of a PR in Kommander repo label Jan 3, 2025
@takirala takirala marked this pull request as ready for review January 3, 2025 07:33
@takirala takirala force-pushed the tga/kubecost-v2 branch 3 times, most recently from ad27542 to f839bb7 Compare January 3, 2025 18:36
@takirala takirala requested a review from mhrabovcin January 3, 2025 19:04
@takirala takirala requested a review from cwyl02 January 3, 2025 19:04
@takirala
feat: drop centralized-kubecost
fd6670b 
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@takirala
feat: upgrade to kubecost v2
b016074 
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@takirala
build: update license manifest
642ecca 
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@takirala
test: update kubecost tests
26e7210 
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@takirala takirala removed the do-not-merge/testing Do not merge because there is still on-going testing label Jan 6, 2025
@takirala
fix: use correct namespace substitution
01168e7 
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@takirala
build: update license manifest
18b1bd6 
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@mesosphere-ci mesosphere-ci added the do-not-merge/testing Do not merge because there is still on-going testing label Jan 7, 2025
@takirala
fix: simplify yq eval command
5f0aab1 
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@takirala
fix: add substitution vars for kubecost HR
471f728 
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@takirala
fix: robust configmap update
2db57b3 
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@takirala takirala merged commit ee38580 into main Jan 8, 2025
42 checks passed
@takirala takirala deleted the tga/kubecost-v2 branch January 8, 2025 03:14
@takirala takirala mentioned this pull request Jan 8, 2025
Merged
2 tasks
rohitkumar0510 pushed a commit that referenced this pull request Feb 5, 2025
@takirala @d2iq-mergebot @rohitkumar0510
feat: upgrade to kubecost v2 (#2959)
9a698d4 
Co-authored-by: d2iq-mergebot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhrabovcin mhrabovcin mhrabovcin approved these changes

@cwyl02 cwyl02 cwyl02 approved these changes

Assignees
No one assigned
Labels
do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo ready-for-review services/centralized-grafana services/centralized-kubecost services/kommander services/kommander-ui services/kubecost services/nkp-insights size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@takirala @coveralls @mhrabovcin @cwyl02 @mesosphere-ci @d2iq-mergebot