New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

listened_at is required #32

Open

Weissnix4711 opened this issue Feb 15, 2024 · 0 comments

Weissnix4711 commented Feb 15, 2024

The listened_at field is required for submitting listens, but we default to None and do not perform any validation for it before calling the API.

Validation should probably be added here for listened_at field for LISTEN_TYPE_SINGLE and LISTEN_TYPE_IMPORT:

liblistenbrainz/liblistenbrainz/utils.py

Line 21 in e9d211b

def _validate_submit_listens_payload(listen_type, listens):

Also, maybe it's worth defaulting to the current time? Or should that be left up to the user?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment