Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jekyll theme for documentation #28

Closed
TobiasNx opened this issue Nov 7, 2023 · 17 comments · Fixed by #43
Closed

Use jekyll theme for documentation #28

TobiasNx opened this issue Nov 7, 2023 · 17 comments · Fixed by #43
Assignees

Comments

@TobiasNx
Copy link
Collaborator

TobiasNx commented Nov 7, 2023

This seems to be a good option. Changing the blue to the metafacture blue otherwise nice simple documentation form.

https://just-the-docs.github.io/just-the-docs/

It allows for searching and a sidebar.

This page shows how to use this template in github pages: https://github.com/just-the-docs/just-the-docs-template/blob/main/README.md

@katauber
Copy link
Member

katauber commented Nov 9, 2023

functional review: @TobiasNx
code review: ?

@TobiasNx TobiasNx assigned dr0i and unassigned katauber Mar 25, 2024
@dr0i
Copy link
Member

dr0i commented Mar 25, 2024

As discussed today we will ask if @Phu2 has time to give it a try.

@dr0i dr0i assigned Phu2 and unassigned dr0i Mar 25, 2024
@Phu2
Copy link
Contributor

Phu2 commented Mar 27, 2024

Note to self: the docs are published as github pages already, see https://metafacture.github.io/metafacture-documentation/ However, the metafacture site oddly links to the (this!) repo of the docs instead.

@TobiasNx
Copy link
Collaborator Author

Note to self: the docs are published as github pages already, see https://metafacture.github.io/metafacture-documentation/ However, the metafacture site oddly links to the (this!) repo of the docs instead.

This is due to the fact that the gh pages version is not ready yet / did not exist yet and the documentation repo was used instead.

@Phu2
Copy link
Contributor

Phu2 commented Mar 27, 2024

First draft is published at https://phu2.github.io/metafacture-documentation/
Still need to adjust the navigation and tweak some colors.
The site will be re-deployed on push to the master branch of https://github.com/Phu2/metafacture-documentation

@TobiasNx
Copy link
Collaborator Author

TobiasNx commented Mar 28, 2024

Structure:
General pages:

  • Readme
  • Getting Started
  • 5 min Intro into MF
  • Approaching a transformation with metafacture

FLUX

  • Flux User Guide
  • Flux Commands

FIX

  • Fix-User-Guide
  • Fix Functions and Cookbook

Java Integration

  • Framework user guide

For Developers

  • Documentation-Maintainer-Guide
  • License

@Phu2
Copy link
Contributor

Phu2 commented Mar 28, 2024

Pages restructered, navigation added.
@TobiasNx You might want to review the redeployed docs https://phu2.github.io/metafacture-documentation/

  • the README.md is left as is for use within the repo
  • parts of the README.md were copied to index.md (Home), flux.md, fix.md and so on
  • there is no "For Developers" level for now, might add later if needed
  • the LICENSE file is replicated as LICENSE.md for display within the jekyll site

@TobiasNx
Copy link
Collaborator Author

TODOs:

  • Use the MF blue
  • Move the MF Icon to the top left corner
  • Some formatting but I am not sure.

If we are done with this, we could invite the team to have a look at this.

@Phu2
Copy link
Contributor

Phu2 commented Mar 28, 2024

Done.
I also tried to fix all links and added a footer.

@Phu2
Copy link
Contributor

Phu2 commented Mar 28, 2024

"Approaching a transformation with metafacture" isn't linked to anywhere (and has no heading). Same with "Maintainer Guide".

@dr0i
Copy link
Member

dr0i commented Apr 2, 2024

'Short cheer here - this looks so much better 👍

@TobiasNx
Copy link
Collaborator Author

TobiasNx commented Apr 2, 2024

Perhaps add the word documentation under the logo in the corner?

Also any way to turn [!NOTE] into
grafik

Seems like there is a way within justthedocs: https://just-the-docs.com/docs/ui-components/callouts/

@TobiasNx
Copy link
Collaborator Author

TobiasNx commented Apr 2, 2024

Also how should we proceed?

@Phu2
Copy link
Contributor

Phu2 commented Apr 3, 2024

New branch https://github.com/metafacture/metafacture-documentation/tree/28-use-jekyll-theme created + corresponding Github Action (on push) for deployment to http://metafacture.github.io/metafacture-documentation/

TobiasNx added a commit that referenced this issue Apr 3, 2024
Phu2 added a commit that referenced this issue Apr 3, 2024
TobiasNx added a commit that referenced this issue Apr 3, 2024
@Phu2 Phu2 moved this from Backlog to Review in Metafacture Apr 9, 2024
@TobiasNx
Copy link
Collaborator Author

Still open merge this with master.

Add a new README.md that links to the documentation and to the markdown pages.
Perhaps we should talk to @dr0i and @fsteeg if they are okay with the remodelling of the documentation repo.

TobiasNx added a commit that referenced this issue Apr 24, 2024
@fsteeg
Copy link
Member

fsteeg commented Apr 29, 2024

The page at http://metafacture.github.io/metafacture-documentation/ looks good to me, but the PR at #43 is still a draft and has not been reviewed (and is not linked to this issue). Shouldn't this go through the regular review process?

@TobiasNx
Copy link
Collaborator Author

The page at http://metafacture.github.io/metafacture-documentation looks good to me, but the PR at #43 is still a draft and has not been reviewed (and is not linked to this issue). Shouldn't this go through the regular review process?

I opened an PR for this and assigned you for review.

TobiasNx added a commit that referenced this issue May 21, 2024
TobiasNx added a commit that referenced this issue May 22, 2024
@fsteeg fsteeg linked a pull request May 23, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Review to Done in Metafacture May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants