Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested design for buttons #5

Merged
merged 4 commits into from
Dec 8, 2024
Merged

Conversation

Adi-204
Copy link
Contributor

@Adi-204 Adi-204 commented Dec 2, 2024

The below is suggested design for buttons. I also installed flowbite in project.

Issue - #2

image

@harshkhandeparkar
Copy link
Member

Where is flowbite used and why?

@Adi-204
Copy link
Contributor Author

Adi-204 commented Dec 3, 2024

Installing Flowbite is not mandatory but by installing it in project will help in modify Flowbite's default styles for future use. It simplifies collaboration with other developers, as they can install the exact same version by running npm install.
If you want to I can remove flowbite from Project Dependencies.

@harshkhandeparkar
Copy link
Member

Installing Flowbite is not mandatory but by installing it in project will help in modify Flowbite's default styles for future use. It simplifies collaboration with other developers, as they can install the exact same version by running npm install. If you want to I can remove flowbite from Project Dependencies.

Please remove it. Try to keep the PR focused on the relevant changes.

@Adi-204
Copy link
Contributor Author

Adi-204 commented Dec 3, 2024

Thank you for the guidance! I'll remove Flowbite from the project dependencies and ensure the PR focuses solely on the relevant changes. Let me know if there's anything else you'd like me to address

Copy link
Collaborator

@saharsh-agrawal saharsh-agrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add animation transitions and add similiar designs to buttons on other pages as well.

@saharsh-agrawal saharsh-agrawal mentioned this pull request Dec 7, 2024
@Adi-204
Copy link
Contributor Author

Adi-204 commented Dec 7, 2024

Changed Design of All Buttons.

@saharsh-agrawal saharsh-agrawal self-requested a review December 7, 2024 11:54
Copy link
Collaborator

@saharsh-agrawal saharsh-agrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try and add transition animations too.

@Adi-204
Copy link
Contributor Author

Adi-204 commented Dec 7, 2024

What do you mean by "add transition animations" with respect to button ?
On hover their are effects already applied.
Can you please specify what exactly you want ?

@saharsh-agrawal
Copy link
Collaborator

The button changes immediately on hover. Try and implement a transition time of let's say 0.5s

@saharsh-agrawal saharsh-agrawal merged commit 3c14d40 into metakgp:main Dec 8, 2024
@saharsh-agrawal
Copy link
Collaborator

The transition isn't working and it isn't even supposed to work on colour-change effects. So merging this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants