Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 update README.md #1166

Merged

Conversation

tuminoid
Copy link
Member

Update build badge URLs, and update/remove non-1.5 related information related to testing etc.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 31, 2023
@tuminoid
Copy link
Member Author

/test-ubuntu-e2e-integration-release-1-5

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve cancel

Looks like the badges still has 1.4 in them

@metal3-io-bot metal3-io-bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
Update build badge URLs, and update/remove non-1.5 related information
related to testing etc.
@tuminoid
Copy link
Member Author

/approve cancel

Looks like the badges still has 1.4 in them

Fixed, good catch.

@tuminoid
Copy link
Member Author

/test-ubuntu-e2e-integration-release-1-5

1 similar comment
@tuminoid
Copy link
Member Author

/test-ubuntu-e2e-integration-release-1-5

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
@tuminoid
Copy link
Member Author

/test-ubuntu-e2e-integration-release-1-5

@tuminoid
Copy link
Member Author

/cc @kashifest

Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2023
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 627f27f into metal3-io:release-1.5 Sep 1, 2023
4 checks passed
@Sunnatillo Sunnatillo deleted the tuomo/update-readme-1.5 branch September 1, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants