New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: 🌱 Bump CAPI to v1.8.0-beta.0 #1845

Closed

Sunnatillo wants to merge 1 commit into metal3-io:main from Nordix:uplift-capi-v1.8.0-beta.o/sunnat

Member

Sunnatillo commented Jul 17, 2024 •

edited

Loading

Uplifts CAPI to v1.8.0-beta.0

ClusterProxy.Apply() function is replaced ClusterProxy.CreateOrUpdate(), later does not accept namespace as an argument.

Fixes #1844

Contributor

metal3-io-bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sunnatillo. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

metal3-io-bot requested review from adilGhaffarDev and mboukhalfa

July 17, 2024 06:54

metal3-io-bot added the size/L label

Member Author

Sunnatillo commented Jul 17, 2024

we need a proper fix

Member

adilGhaffarDev commented Jul 17, 2024

we need a proper fix

I can take a look, seems like there are some changes in CAPI e2e framework.

Sunnatillo force-pushed the uplift-capi-v1.8.0-beta.o/sunnat branch from 2ff7037 to 4f41aa6 Compare

July 18, 2024 11:44

adilGhaffarDev mentioned this pull request

🌱 Bump sigs.k8s.io/cluster-api from 1.7.0-rc.0.0.20240704092232-a7f5043dee2a to 1.8.0-beta.0 #1847

Closed

Sunnatillo force-pushed the uplift-capi-v1.8.0-beta.o/sunnat branch from 4f41aa6 to 6705d18 Compare

July 18, 2024 12:00

Member Author

Sunnatillo commented Jul 18, 2024

/test ?

Contributor

metal3-io-bot commented Jul 18, 2024

@Sunnatillo: The following commands are available to trigger required jobs:

/test build
/test generate
/test gomod
/test manifestlint
/test markdownlint
/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main
/test shellcheck
/test test
/test unit

The following commands are available to trigger optional jobs:

/test metal3-centos-e2e-basic-test-main
/test metal3-centos-e2e-feature-test-main-features
/test metal3-centos-e2e-feature-test-main-pivoting
/test metal3-centos-e2e-feature-test-main-remediation
/test metal3-e2e-1-26-1-27-upgrade-test-main
/test metal3-e2e-1-27-1-28-upgrade-test-main
/test metal3-e2e-1-28-1-29-upgrade-test-main
/test metal3-e2e-clusterctl-upgrade-test-main
/test metal3-ubuntu-e2e-basic-test-main
/test metal3-ubuntu-e2e-feature-test-main-features
/test metal3-ubuntu-e2e-feature-test-main-pivoting
/test metal3-ubuntu-e2e-feature-test-main-remediation

Use /test all to run the following jobs that were automatically triggered:

build
generate
gomod
manifestlint
markdownlint
unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Member Author

Sunnatillo commented Jul 18, 2024

/test metal3-e2e-clusterctl-upgrade-test-main
PR has related changes

Member Author

Sunnatillo commented Jul 18, 2024

/test metal3-ubuntu-e2e-integration-test-main
/test metal3-centos-e2e-integration-test-main

Member Author

Sunnatillo commented Jul 18, 2024

/test metal3-e2e-clusterctl-upgrade-test-main

Sunnatillo force-pushed the uplift-capi-v1.8.0-beta.o/sunnat branch from 6705d18 to 72b4044 Compare

July 18, 2024 13:34

Member Author

Sunnatillo commented Jul 18, 2024

/test metal3-e2e-clusterctl-upgrade-test-main

Sunnatillo force-pushed the uplift-capi-v1.8.0-beta.o/sunnat branch from 72b4044 to 721fed2 Compare

July 22, 2024 11:51

Member Author

Sunnatillo commented Jul 22, 2024

/test metal3-e2e-clusterctl-upgrade-test-main

Sunnatillo changed the title ~~🌱 Bump CAPI to v1.8.0-beta.0~~ WIP: 🌱 Bump CAPI to v1.8.0-beta.0

metal3-io-bot added the do-not-merge/work-in-progress label

Sunnatillo force-pushed the uplift-capi-v1.8.0-beta.o/sunnat branch from 721fed2 to f35a790 Compare

July 22, 2024 13:03

Member Author

Sunnatillo commented Jul 22, 2024

/test metal3-e2e-clusterctl-upgrade-test-main

Sunnatillo force-pushed the uplift-capi-v1.8.0-beta.o/sunnat branch from f35a790 to a0846a0 Compare

July 22, 2024 14:29

Member Author

Sunnatillo commented Jul 22, 2024

/test metal3-e2e-clusterctl-upgrade-test-main

Sunnatillo force-pushed the uplift-capi-v1.8.0-beta.o/sunnat branch from a0846a0 to 41d302e Compare

July 23, 2024 07:51

Member Author

Sunnatillo commented Jul 23, 2024

/test metal3-e2e-clusterctl-upgrade-test-main

Sunnatillo force-pushed the uplift-capi-v1.8.0-beta.o/sunnat branch 2 times, most recently from de3b3d8 to 0f2ec09 Compare

July 23, 2024 08:23

Member Author

Sunnatillo commented Jul 23, 2024

/test metal3-e2e-clusterctl-upgrade-test-main

Sunnatillo force-pushed the uplift-capi-v1.8.0-beta.o/sunnat branch from 0f2ec09 to 4d4eb9a Compare

July 23, 2024 09:05

Sunnatillo force-pushed the uplift-capi-v1.8.0-beta.o/sunnat branch from 60ec113 to dd17f53 Compare

July 23, 2024 13:20

Member Author

Sunnatillo commented Jul 23, 2024

/test metal3-e2e-clusterctl-upgrade-test-main

Sunnatillo force-pushed the uplift-capi-v1.8.0-beta.o/sunnat branch from dd17f53 to ab16413 Compare

July 23, 2024 14:08

Member Author

Sunnatillo commented Jul 23, 2024

/test metal3-e2e-clusterctl-upgrade-test-main

2 similar comments

Member Author

Sunnatillo commented Jul 23, 2024

/test metal3-e2e-clusterctl-upgrade-test-main

Member Author

Sunnatillo commented Jul 24, 2024

/test metal3-e2e-clusterctl-upgrade-test-main

Sunnatillo force-pushed the uplift-capi-v1.8.0-beta.o/sunnat branch from ab16413 to 39761cf Compare

July 25, 2024 07:21

Member Author

Sunnatillo commented Jul 25, 2024

/test metal3-e2e-clusterctl-upgrade-test-main

Sunnatillo force-pushed the uplift-capi-v1.8.0-beta.o/sunnat branch from 39761cf to 692e774 Compare

July 25, 2024 08:24

Member Author

Sunnatillo commented Jul 25, 2024

/test metal3-e2e-clusterctl-upgrade-test-main

Sunnatillo force-pushed the uplift-capi-v1.8.0-beta.o/sunnat branch from 692e774 to 98cd127 Compare

July 25, 2024 10:04

adilGhaffarDev mentioned this pull request

🌱 Bump sigs.k8s.io/cluster-api from 1.7.0-rc.0.0.20240704092232-a7f5043dee2a to 1.8.0-beta.1 #1855

Closed

Member Author

Sunnatillo commented Jul 25, 2024

/test metal3-e2e-clusterctl-upgrade-test-main

metal3-io-bot added the needs-rebase label

Sunnatillo force-pushed the uplift-capi-v1.8.0-beta.o/sunnat branch 2 times, most recently from 89ba43a to e7ee9b4 Compare

July 25, 2024 10:47

metal3-io-bot removed the needs-rebase label

Member Author

Sunnatillo commented Jul 25, 2024

/test metal3-e2e-clusterctl-upgrade-test-main

Member

adilGhaffarDev commented Jul 25, 2024

@Sunnatillo please change the title and description too to beta1 from beta0.


          Bump CAPI to v1.8.0-beta.1

030762a

Signed-off-by: Sunnatillo <[email protected]>

Sunnatillo force-pushed the uplift-capi-v1.8.0-beta.o/sunnat branch from e7ee9b4 to 030762a Compare

July 25, 2024 13:00

Member Author

Sunnatillo commented Jul 25, 2024

/test metal3-e2e-clusterctl-upgrade-test-main

Contributor

metal3-io-bot commented Jul 25, 2024

@Sunnatillo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
metal3-e2e-clusterctl-upgrade-test-main	`030762a`	link	false	`/test metal3-e2e-clusterctl-upgrade-test-main`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Contributor

metal3-io-bot commented Jul 25, 2024

@Sunnatillo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
metal3-e2e-clusterctl-upgrade-test-main	`030762a`	link	false	`/test metal3-e2e-clusterctl-upgrade-test-main`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Contributor

metal3-io-bot commented Jul 26, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

metal3-io-bot added the needs-rebase label

adilGhaffarDev mentioned this pull request

🌱 Uplift CAPI to v1.8.0-rc.0 #1859

Merged

Member Author

Sunnatillo commented Jul 31, 2024

/close
Superseeded by #1859

Contributor

metal3-io-bot commented Jul 31, 2024

@Sunnatillo: Closed this PR.

In response to this:

/close
Superseeded by #1859

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

metal3-io-bot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress needs-rebase size/L