🌱 Use wget while downloading image #2110
Conversation
metal3-io-bot
added
the
size/M
|
/test metal3-centos-e2e-feature-test-main-pivoting |
|
/test ? |
|
@adilGhaffarDev: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test metal3-centos-e2e-feature-test-main-features |
kashifest
force-pushed
the
kashif/fix-downloadImage-withExponentialBackoff
branch
from
555efb4 to
5ce3436
Compare
|
/test metal3-centos-e2e-feature-test-main-features /test metal3-centos-e2e-feature-test-main-pivoting |
Recently we have experienced net.OpError error or http2streamerror error while downloading image quite frequently. This PR uses wget instead which is more resilient to http/network issues. We should change it to httpGet when network improves again. Signed-off-by: Kashif Khan <[email protected]>
kashifest
force-pushed
the
kashif/fix-downloadImage-withExponentialBackoff
branch
from
5ce3436 to
f4dbb7e
Compare
metal3-io-bot
added
size/S
|
/test metal3-centos-e2e-feature-test-main-features /test metal3-centos-e2e-feature-test-main-pivoting |
kashifest
changed the title
Just noting that implementing Go with HTTP/1 might be worth a try. Wget on Ubuntu is still not built with HTTP/2 by default, so it might be more robust choice for Go client as well. Go by default is using HTTP/2 and as you wrote on the summary, seems to be source of the issues. |
Yep for now, lets take the CI back, I will do a followup soon |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adilGhaffarDev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/test metal3-ubuntu-e2e-integration-test-main metal3-centos-e2e-integration-test-main |
|
/test metal3-ubuntu-e2e-integration-test-main |
metal3-io-bot
deleted the
kashif/fix-downloadImage-withExponentialBackoff
branch
|
/cherry-pick release-1.8 |
|
@kashifest: new pull request created: #2116 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@kashifest: new pull request created: #2117 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Recently we have experienced net.OpError error or http2streamerror error while downloading image quite frequently. This PR uses wget instead which is more resilient to http/network issues. We should change it to httpGet when network improves again.