🌱 Update Dockerfile #591
🌱 Update Dockerfile #591
Conversation
Update Dockerfile, add basic labels and speed-up the build process: - use curl instead of git for repository download - use build-time bash shell with '-exo pipefail' for error catching - add proper labeling of resulting image - further improve image size by reducing layers number using one RUN command. - other minor improvements Signed-off-by: Miłosz Linkiewicz <[email protected]>
|
|
||
| USER ironic | ||
| WORKDIR / | ||
| ENTRYPOINT ["/bin/bash"] |
There was a problem hiding this comment.
The entrypoint does not look right.
There was a problem hiding this comment.
this is also probably not needed
| LABEL org.opencontainers.image.title="Metal3 Ironic Container" | ||
| LABEL org.opencontainers.image.description="Container image to run OpenStack Ironic as part of Metal³" | ||
| LABEL org.opencontainers.image.documentation="https://github.com/metal3-io/ironic-image/blob/main/README.md" | ||
| LABEL org.opencontainers.image.version="v26.0.1" |
There was a problem hiding this comment.
Good call. We'd need to update our releasing documentation to bump this (I expect the next version to be 26.1.0 or 27.0.0). CC @elfosardo
There was a problem hiding this comment.
We should not have anything but latest in main tho
There was a problem hiding this comment.
this is ok for released branches, as Dmitry said probably need to add this when we cut a new branch
in main we should just have latest
|
Many reasonable changes here, but I'd slightly prefer several pull requests so that we can consider them separately. A couple of comments (+ requesting input from Riccardo) |
| @@ -7,25 +9,33 @@ ARG BASE_IMAGE=quay.io/centos/centos:stream9 | |||
| FROM $BASE_IMAGE AS ironic-builder | |||
|
|
|||
| ARG IPXE_COMMIT_HASH=119c415ee47aaef2717104fea493377aa9a65874 | |||
| ARG MAKEFLAGS="-j100" | |||
There was a problem hiding this comment.
A 100 jobs, I don't think thats reasonable default.
There was a problem hiding this comment.
no need to set MAKEFLAGS at all
| LABEL org.opencontainers.image.url="https://github.com/metal3-io/ironic-image" | ||
| LABEL org.opencontainers.image.title="Metal3 Ironic Container" | ||
| LABEL org.opencontainers.image.description="Container image to run OpenStack Ironic as part of Metal³" | ||
| LABEL org.opencontainers.image.documentation="https://github.com/metal3-io/ironic-image/blob/main/README.md" |
There was a problem hiding this comment.
Documentation would maybe better point to our user-guide?
There was a problem hiding this comment.
I agree, let's point to the user guide
|
/ok-to-test |
metal3-io-bot
added
the
ok-to-test
|
thanks for the patch, appreciate the improvements |
metal3-io-bot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Update Dockerfile, add basic labels and speed-up the build process:
curlinstead ofgitfor repository download-exo pipefailfor error catchingENTRYPOINTaddedUSERadded