Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metanorma collection collection.yaml does not work without explicit options #283

Closed
ronaldtse opened this issue Sep 7, 2022 · 0 comments · Fixed by #286
Closed

metanorma collection collection.yaml does not work without explicit options #283

ronaldtse opened this issue Sep 7, 2022 · 0 comments · Fixed by #286
Assignees
@abunashir
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

This refers to a bug in the functionality implemented in #205

Right now,

bundle exec metanorma collection collection.yml
> No value provided for required options '--output-folder'

This is wrong, because the option is already provided in the collection.yaml file.
https://github.com/metanorma/bipm-si-brochure/blob/a588390f6d323ae9df8ad119027d440543bf5cd8/collection.yml#L30

Clearly the metanorma collection command is not reading the YAML options properly. This needs to be fixed.

See: metanorma/bipm-si-brochure#186 (comment) on reproducing this problem.
@ronaldtse ronaldtse added the bug Something isn't working label Sep 7, 2022
@ronaldtse ronaldtse moved this to 🆕 New in Metanorma Sep 7, 2022
@ronaldtse ronaldtse moved this from 🆕 New to 🌋 Urgent in Metanorma Sep 7, 2022
This was referenced Sep 7, 2022
Merged
Closed
abunashir added a commit that referenced this issue Sep 11, 2022
@abunashir
Fix collection option related issue
9e24967 
We have recently added support to provide collection options either
as an command line arguments or options in the collection file. But
that is only working on the site interface, and the collection cli
still expect the `output-folder` as required option.

This commit changes that, so it's not required anymore and it will
try to read the option from the file, and if none of those source
has this value, only then raise a missing option error.

Fixes #283
@abunashir abunashir mentioned this issue Sep 11, 2022
Merged
abunashir added a commit that referenced this issue Sep 11, 2022
@abunashir
Fix collection option related issue
e8d4b70 
We have recently added support to provide collection options either
as an command line arguments or options in the collection file. But
that is only working on the site interface, and the collection cli
still expect the `output-folder` as required option.

This commit changes that, so it's not required anymore and it will
try to read the option from the file, and if none of those source
has this value, only then raise a missing option error.

Fixes #283
abunashir added a commit that referenced this issue Sep 14, 2022
@abunashir
Fix collection option related issue
da08dcc 
We have recently added support to provide collection options either
as an command line arguments or options in the collection file. But
that is only working on the site interface, and the collection cli
still expect the `output-folder` as required option.

This commit changes that, so it's not required anymore and it will
try to read the option from the file, and if none of those source
has this value, then it will use the source as output directory,
and to keep this file separated it will use the `source/output`

Fixes #283
abunashir added a commit that referenced this issue Sep 14, 2022
@abunashir
Fix collection option related issue
65a5ace 
We have recently added support to provide collection options either
as an command line arguments or options in the collection file. But
that is only working on the site interface, and the collection cli
still expect the `output-folder` as required option.

This commit changes that, so it's not required anymore and it will
try to read the option from the file, and if none of those source
has this value, then it will use the source as output directory,
and to keep this file separated it will use the `source/output`

Fixes #283
abunashir added a commit that referenced this issue Sep 17, 2022
@abunashir
Fix collection option related issue
4636428 
We have recently added support to provide collection options either
as an command line arguments or options in the collection file. But
that is only working on the site interface, and the collection cli
still expect the `output-folder` as required option.

This commit changes that, so it's not required anymore and it will
try to read the option from the file, and if none of those source
has this value, then it will use the source as output directory.

Fixes #283
Repository owner moved this from 🌋 Urgent to ✅ Done in Metanorma Sep 26, 2022
@ronaldtse ronaldtse removed this from Metanorma Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abunashir abunashir

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix collection option related issue metanorma/metanorma-cli
2 participants
@ronaldtse @abunashir