Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF: Add new vertical layout #226

Closed
21 of 24 tasks
Intelligent2013 opened this issue Oct 18, 2024 · 37 comments
Closed
21 of 24 tasks

PDF: Add new vertical layout #226

Intelligent2013 opened this issue Oct 18, 2024 · 37 comments
Assignees
Labels
enhancement New feature or request

Comments

@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Oct 18, 2024

In continue of metanorma/mn-native-pdf#713.

As titled, based on the new JIS layout JIS_Template_traditional_blue_v2_traditional.pdf.

To do (draft list):

Known issues:

@Intelligent2013 Intelligent2013 added the enhancement New feature or request label Oct 18, 2024
@Intelligent2013 Intelligent2013 self-assigned this Oct 18, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Metanorma Oct 18, 2024
@ronaldtse
Copy link

Here's an updated file for reference:

use font NotoSansJP-Thin, NotoSerifJP-ExtraLight and Source Sans in the XSLT

I've used "Noto Serif JP" "Medium" to replace the Italic text, so we don't need Source Sans.

put cover page image into the back cover page

It's a mirrored front-back image of the front cover page. If possible allow using a separate front/back cover page.

Thanks!

Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Oct 19, 2024
@Intelligent2013
Copy link
Contributor Author

add new parameters :presentation-metadata-color-cover-page-background-1:, :presentation-metadata-color-cover-page-background-2: for vertical stripes (with opacity) on the cover page

The parameter :presentation-metadata-color-cover-page-background-1: for
image

The parameter :presentation-metadata-color-cover-page-background-2: for
image

Also we need two parameters for opacities:

  • :presentation-metadata-color-cover-page-background-opacity-1: 0.58
  • :presentation-metadata-color-cover-page-background-opacity-2: 0.75

@Intelligent2013 Intelligent2013 moved this from 🆕 New to 🏗 In progress in Metanorma Oct 19, 2024
Intelligent2013 added a commit that referenced this issue Oct 20, 2024
Intelligent2013 added a commit that referenced this issue Oct 20, 2024
@Intelligent2013
Copy link
Contributor Author

Intelligent2013 commented Oct 20, 2024

The footer contains the last on page clause title. First depth clause:

image

@Intelligent2013
Copy link
Contributor Author

@ronaldtse there are question about numbers in header/footer:

  • the number in header means :edition:?
  • the number in footer means the page number? Just mistakenly all page number are 2?
  • both numbers in header/footer ToC page should be in parenthesis?

Examples:

  • ToC page

    • header - number 1 in parenthesis
      image
    • footer - number 2 in parenthesis
      image
  • first document page

    • header - number 1
      image
    • footer - number 2
      image
  • last document page - same

Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Oct 20, 2024
@Intelligent2013
Copy link
Contributor Author

@ronaldtse could you check the fonts which are used on the cover page in the source Adobe Illustrator file.
Adobe Acrobat shows Noto Serif Extra Light for all texts:
image

but the rendered fonts looks so:
image

I've tried to use Noto Serif JP Medium, but it looks different than in the source PDF(generated from AI):
image

Also, Adobe Acrobat in the document properties shows 7 fonts Noto Serif Extra Light:
image

Thanks.

@ronaldtse
Copy link

@Intelligent2013 I think this is because I’m using Noto Sans JP “Variable” that can realize all weights. It’s not Extra Light.

@Intelligent2013
Copy link
Contributor Author

Actually the fonts Noto Serif JP Medium, Noto Serif JP Bold and Noto Serif Black are using on the cover page text.

Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Dec 8, 2024
@Intelligent2013
Copy link
Contributor Author

Intelligent2013 commented Dec 8, 2024

Found 8 characters which require to use the dedicated characters:

  • U+3001 IDEOGRAPHIC COMMA (、) to U+FE11 PRESENTATION FORM FOR VERTICAL IDEOGRAPHIC COMMA (︑)
  • U+FE50 SMALL COMMA (﹐) to U+FE10 PRESENTATION FORM FOR VERTICAL COMMA (︐)
  • U+FE51 SMALL IDEOGRAPHIC COMMA (﹑) to U+FE11 PRESENTATION FORM FOR VERTICAL IDEOGRAPHIC COMMA (︑)
  • U+FF0C FULLWIDTH COMMA (,) to U+FE10 PRESENTATION FORM FOR VERTICAL COMMA (︐)
  • U+FF1A FULLWIDTH COLON (:) to U+FE13 PRESENTATION FORM FOR VERTICAL COLON (︓)
  • U+FF1B FULLWIDTH SEMICOLON (;) to U+FE14 PRESENTATION FORM FOR VERTICAL SEMICOLON
  • U+FF01 FULLWIDTH EXCLAMATION MARK (!) to U+FE15 PRESENTATION FORM FOR VERTICAL EXCLAMATION MARK (︕)
  • U+FF1F FULLWIDTH QUESTION MARK (?) to U+FE16 PRESENTATION FORM FOR VERTICAL QUESTION MARK (︖)

Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Dec 9, 2024
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Dec 9, 2024
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Dec 13, 2024
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Dec 13, 2024
Intelligent2013 added a commit to metanorma/metanorma.org that referenced this issue Dec 15, 2024
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Dec 16, 2024
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Dec 16, 2024
Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Dec 16, 2024
@Intelligent2013
Copy link
Contributor Author

Intelligent2013 commented Dec 16, 2024

Latest generated PDF: 20241216.vertical.jis.example.pdf

Issues found:

@ronaldtse
Copy link

@Intelligent2013 some of those layout issues are vertical layout implementation issues. Can you post them separately so we can fix them in code? Thanks.

@Intelligent2013
Copy link
Contributor Author

Separated issues added.
This thread is too long, so closing.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Metanorma Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants