Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend addition to the getAssetProof response #54

Open
nickfrosty opened this issue Apr 6, 2023 · 1 comment
Open

Recommend addition to the getAssetProof response #54

nickfrosty opened this issue Apr 6, 2023 · 1 comment

Comments

@nickfrosty
Copy link

Problem

When building a transfer instruction for compressed NFTs, developers and sdks are required to get a valid proof via the getAssetProof method. But also the asset's data_hash and creator_hash from the getAsset method too.

The end result is that nearly every time a developer needs to build the transfer instruction, they have to make 2 RPC calls to get all the data that is needed to completely build the transfer instruction (or they have to already have some values cached elsewhere).

Solution

When fetching data via the getAssetProof method, I recommend adding the asset's current data_hash and creator_hash within the response. This would allow 1 less round trip to the ReadApi for not that much extra data in the original response.

Maybe even include the entire compression field data from the getAsset method? But this is a less good option.

@austbot
Copy link
Collaborator

austbot commented Apr 15, 2023

This is a great suggestion!
I agree with it, want to make a pr?

muhitrhn pushed a commit to muhitrhn/digital-asset-rpc-infrastructure that referenced this issue Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants