Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getNftEditions rpc method to das #216

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add getNftEditions rpc method to das #216

wants to merge 8 commits into from

Conversation

Nagaprasadvr
Copy link
Collaborator

@Nagaprasadvr Nagaprasadvr commented Nov 15, 2024 •
edited
Loading

  • add getNftEditions rpc method
  • pass a master edition mint to fetch editions accounts associated with master edition and return them
  • add integration test

@Nagaprasadvr Nagaprasadvr force-pushed the das-50-add-getnfteditions-rpc-method-to-das branch 3 times, most recently from 17e8045 to 650be7e Compare November 21, 2024 12:18
@Nagaprasadvr Nagaprasadvr force-pushed the das-50-add-getnfteditions-rpc-method-to-das branch from 650be7e to 4dd0fc7 Compare November 21, 2024 12:23
kespinola
kespinola requested changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@kespinola kespinola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primarily need to account for pagination and could you please leave some notes on the 2-step indexing to link master edition to an edition for the readers?

digital_asset_types/src/dao/scopes/asset.rs Outdated Show resolved Hide resolved
digital_asset_types/src/dao/scopes/asset.rs Outdated Show resolved Hide resolved
danenbm
danenbm approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@danenbm danenbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great!!! Approved with just a couple questions/nit comment.

program_transformers/src/token_metadata/mod.rs Outdated Show resolved Hide resolved
program_transformers/src/token_metadata/v1_asset.rs Outdated Show resolved Hide resolved
program_transformers/src/token_metadata/master_edition.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danenbm danenbm danenbm approved these changes

@kespinola kespinola Awaiting requested review from kespinola

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nagaprasadvr @kespinola @danenbm