Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECMWF HINDCAST grib reader #4

Closed
ecasellas opened this issue Jul 14, 2023 · 1 comment · Fixed by #8
Closed

ECMWF HINDCAST grib reader #4

ecasellas opened this issue Jul 14, 2023 · 1 comment · Fixed by #8
Assignees
Labels
enhancement New feature or request

Comments

@ecasellas
Copy link
Contributor

Unimodel should read ECMWF HINDCAST grib files. A function named read_ecmwf_hindcast_grib can be added to unimodel/io/readers_nwp.py. To obtain metadata, _get_ecmwf_metadata may be used.

@ecasellas ecasellas moved this to Backlog in postproc Jul 14, 2023
@ecasellas ecasellas added the enhancement New feature or request label Jul 14, 2023
@ecasellas ecasellas added this to the unimodel v0.2.4 milestone Aug 2, 2023
@ecasellas ecasellas moved this from Backlog to Todo in postproc Aug 4, 2023
@sotis-am sotis-am moved this from Todo to In Progress in postproc Aug 7, 2023
@sotis-am
Copy link
Contributor

sotis-am commented Aug 7, 2023

The ECMWF hindcast grib files don't have the same file name format as the ECMWF-HRES or ECMWF-ENS. Usually the valid time part is in the form of mmddhhii where mm is valid month, dd is valid day, hh is valid hour and ii is valid minute (https://confluence.ecmwf.int/display/DAC/File+naming+convention+and+format+for+real-time+data). However, for the ECMWF hindcast the valid time is in the form of mmdd____ (note the underscores instead of hh and ii).

Instead of adding a new reader, we can use the generic read_ecmwf_grib modified in #6 and change the valid_time parameter for valid_month, valid_day and valid_run in the importers module.

@sotis-am sotis-am moved this from In Progress to Done in postproc Aug 7, 2023
@sotis-am sotis-am closed this as completed Aug 8, 2023
ecasellas pushed a commit that referenced this issue Oct 25, 2023
PME-12 Lectura model ICON

Approved-by: Enric Casellas Masana
sotis-am pushed a commit that referenced this issue Jan 17, 2024
PME-12 Lectura model ICON

Approved-by: Enric Casellas Masana
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants