-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Meteor.connectWith<Service> for services used by app #2
Comments
This would somehow require the UI logic to distinguish between the two calls This was achieved, e.g., using |
This could probably be done with an option to e.g. Meteor.loginWithGoogle({..., loginOtherAccount: false, ...}); |
I don't want to make |
Instead of requiring that client code be changed to handle the typical case of not switching users, how about having the server code assume that the user was trying to add a service instead of switch users, and throw a "logout to switch" error to abort the login? To handle the case when a user actually does want to switch, we could add FWIW, the |
Solid ideas, feels like if we throw |
Please consider that changing behaviour of client-side calls using different parameters is not safe, since a malicious user could always make the same call withuot the correct parameters for the current context. |
@zimme, that was exactly my thinking. @splendido, in all the proposals we've been discussing, security is still enforced on the server. Extra client-side parameters and methods are only used to communicate user intent. |
@brettle I was referring to the above proposal from @zimme Meteor.loginWithGoogle({..., loginOtherAccount: false, ...}); which is more than fine in this case since the request would be to link another account to the currently logged in user which, in case, would be the user's intended behaviour. Other cases could put it the unsafe way. |
This is to prevent another account from logging in when you wanna add a service to the currently logged in account and there already are another meteor account which has this service.
With
Meteor.loginWith<service>
that account will be logged in.The text was updated successfully, but these errors were encountered: