Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase 1 - extract model api V2 (wip for Review) DO NOT MERGE #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Sing-Li
Copy link

@Sing-Li Sing-Li commented May 1, 2016

  • differentiate between code running on the client and on the server
  • rename ModelUser to the more descriptive AccountsProvider
  • only use (subclasses of) AccountsProvider on the server
  • Remove DDP connection dependency from AccountsCommon
  • remove setting of this.users from AccountsProvider (in discussion)
  • Make user() abstract and implement separately on the client and server.
  • Accept DDP connection on AccountsClient
  • Move _initConnection to AccountsClient
  • initialize this.users on the client.
  • Client-side test code continue to use the minimongo API to access the users collection; full mutation support
  • Pass AccountsProvider instance when creating AccountServer (figure out connection management - mongo vs other providers)
  • Publish current user to users collection from server (TBD)
  • Publish other users from server, design new API (TBD)
  • Add this.accountsProvider on server
  • implement backwards compatible method for caller wanting this.users when AccountsProvider is mongodb (in discussion)
  • rename findSingle to findById
  • replace/rename findCurrentUser and findSingleLoggedIn, perhaps with expanded findById (opting for rename vs combine, in consideration of non-mongo providers)
  • rename insertHLoginToken to insertHashedLoginToken
  • cleanup and/or remove findUsersInServices and getMongoUsersForReactiveWork
  • pass all unit tests

…r instead of Meteor.users; add unit tests to ensure compatibility when provider is mongo for legacy code
@Sing-Li
Copy link
Author

Sing-Li commented May 8, 2016

  • added Meteor.dataProvider on server
  • ensure all server code in unit tests access only Meteor.dataProvider and not Meteor.users
  • added new unit tests for `Meteor.users' access compatibility when data provider is mongo
  • use Meteor 1.3.2.4 dev bundle

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants