Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration with pyaro repeats name a lot #1414

Open
magnusuMET opened this issue Nov 20, 2024 · 1 comment
Open

Configuration with pyaro repeats name a lot #1414

magnusuMET opened this issue Nov 20, 2024 · 1 comment
Assignees
Labels
api Planned changes in API (not backwards compatible) user-friendliness Updates that improve ease of use
Milestone

Comments

@magnusuMET
Copy link
Collaborator

The configuration when using pyaro has needlessy many occurences of the same name, as seen in the following configuration for a run using the EEA pyaro-reader.

{
  "obs_cfg": {
    "EEA-unverified": {
      "obs_id": "EEA-unverified",
      "obs_config": {
        "name": "EEA-unverified",
        "data_id": "eeareader",
      },
      "obs_name": "EEA-unverified"
    }
}

We should find a new config setup before pyaro is used in too many places

@magnusuMET magnusuMET added api Planned changes in API (not backwards compatible) user-friendliness Updates that improve ease of use labels Nov 20, 2024
@magnusuMET magnusuMET added this to the m2024-12 milestone Nov 20, 2024
@heikoklein heikoklein changed the title Configuration with pyaero repeats name a lot Configuration with pyaro repeats name a lot Nov 21, 2024
@lewisblake
Copy link
Member

Agreed some clean up would be nice. Here is a short explanation of what things currently mean

{
  "obs_cfg": {
    "EEA-unverified": { # this is user-defined and can be anything you want. shown on webpage if `var_web_interface` not defined
      "obs_id": "EEA-unverified", # this is required by ObsEntry. In vanilla pyaerocom, maps to a obs network defined in paths.ini
      "obs_config": { # pyaro stuff, name matching obs_id might be redundant, probably should talk with Daniel
        "name": "EEA-unverified",
        "data_id": "eeareader", # maybe pyaro_id would be clearer
      },
      "obs_name": "EEA-unverified" # this get created when using a getter on a ObsEntry instance. Either is the var_web.interface name if provided, or it's the key supplied by the user
    }
}

@lewisblake lewisblake modified the milestones: m2024-12, m2025-01 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Planned changes in API (not backwards compatible) user-friendliness Updates that improve ease of use
Projects
None yet
Development

No branches or pull requests

3 participants