Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modelmaps #1444

Open
wants to merge 10 commits into
base: main-dev
Choose a base branch
from
Open

Fix modelmaps #1444

wants to merge 10 commits into from

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented Dec 4, 2024

Change Summary

This PR tries to improve modelmaps_engine after some crashes by cams2_83

Related issue number

Fixes #1443

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@dulte dulte added the bug 🐛 Something isn't working label Dec 4, 2024
@dulte dulte added this to the m2025-01 milestone Dec 4, 2024
@dulte dulte self-assigned this Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.38%. Comparing base (11c11fb) to head (b655a38).
Report is 36 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/aeroval/modelmaps_engine.py 50.00% 4 Missing ⚠️
pyaerocom/io/cams2_83/reader.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1444      +/-   ##
============================================
- Coverage     78.43%   78.38%   -0.05%     
============================================
  Files           137      138       +1     
  Lines         20963    20996      +33     
============================================
+ Hits          16442    16458      +16     
- Misses         4521     4538      +17     
Flag Coverage Δ
unittests 78.38% <46.66%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dulte
Copy link
Collaborator Author

dulte commented Dec 4, 2024

I've might have fixed the bug now (needs more testing by charlie), but the original tests for modelmaps_engine are very bare-bones (that's why the bug was not caught), so I'll add more and better tests before reviewing

@dulte dulte requested a review from lewisblake December 13, 2024 09:11
@dulte dulte marked this pull request as ready for review December 13, 2024 09:11
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment to maybe remove

@@ -219,7 +219,7 @@ def check_files(paths: list[Path]) -> list[Path]:


class ReadCAMS2_83(GriddedReader):
FREQ_CODES = dict(hour="hourly", day="daily", month="monthly", fullrun="yearly")
FREQ_CODES = dict(hour="hourly") # , day="daily", month="monthly", fullrun="yearly")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove dead code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with modelmaps_engine
2 participants