Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phone number to duplicates algorithm #939

Closed
sarahlazarich opened this issue Nov 12, 2024 · 3 comments
Closed

Add phone number to duplicates algorithm #939

sarahlazarich opened this issue Nov 12, 2024 · 3 comments

Comments

@sarahlazarich
Copy link
Collaborator

sarahlazarich commented Nov 12, 2024

Spike
Draft PR

As a user in DPP looking at duplicate applications,
I want to check for duplicate applications by phone number in addition to the other rules,
So that I can identify apps submitted with the same phone number.

Notes:

  • Some performance testing is probably going to be involved here?

AC:

  • Duplicate group for phone number is added
  • Duplicates process is performant

Work Remaining After Spike:

  • Frontend logic for mapping phoneNumber as Phone Number
  • Backend tests (especially on combination logic)
  • (Optional) Optimizations
    • exclude listings with the following statuses: draft, pending, changes required
    • When looping through listings, break/skip early when there are no application_flagged_set_possibilities found
@sarahlazarich
Copy link
Collaborator Author

Amount of code needed for this is relatively small
Biggest thing we need to think about is the performance
Would increase the views table by a lot
We don't save phone numbers by household member, do we? Yes - def need to test here

This is going to be really hard to test
Need a large set of data, see what happens - test locally with a large set of data (use HBA) just put it in doorway
Would be really interested in seeing how much more additional we could check

Start by looking in the database maybe? Check numbers in HBA to present it first
Not hard to implement just requires testing

@sarahlazarich
Copy link
Collaborator Author

Start with spike first

@sarahlazarich
Copy link
Collaborator Author

based on spike, doorway elected not to pull this in, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant