Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic factories with FactoryGirl #49

Open
diegoamc opened this issue May 29, 2015 · 0 comments
Open

Generic factories with FactoryGirl #49

diegoamc opened this issue May 29, 2015 · 0 comments

Comments

@diegoamc
Copy link
Contributor

Today, everytime we have to modify a factory, we have to modify it in at least 3 different projects. For example, if we change the ReadingGroup factory on KalibroConfigurations project, we would also need to change the code on KalibroProcessor, KalibroClient and Prezento.

As KalibroClient is used by Prezento and KalibroProcessor, we'd like to import common factories directly from KalibroClient on those projects. That way, we would avoid some duplication.

What we need to do is to refactor those factories to sequence the ids, use associations and correct the use of traits (we don't need to create new factory names for each new trait).
Next, we have to find a way to import them on KalibroProcess and Prezento.
Finally, it would be even better if there is a way to import them on KalibroConfigurations too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant