Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid repository URL on branch retrieval #88

Open
rafamanzo opened this issue Nov 9, 2015 · 1 comment
Open

Handle invalid repository URL on branch retrieval #88

rafamanzo opened this issue Nov 9, 2015 · 1 comment
Labels

Comments

@rafamanzo
Copy link
Member

Invalid URL errors on branch retrieval are returned by processor with status 5XX (unprocessable_entity).

KalibroClient handles such status raising RequestErrors which finally are not expected by clients like Prezento.

@rafamanzo rafamanzo added the bug label Nov 9, 2015
@rafamanzo
Copy link
Member Author

This can be fixed by adding the following behaviour to the Repository#branches method:

  1. Rescue RequestError
  2. Check if it matches one of the KalibroProcessor's messages
  3. Raise a new error (you should create a new error class)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant