You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before, our business logic was that one KalibroModule could be related to many ModuleResults.
That logic has changed. Now, a KalibroModule only relates to one ModuleResult.
But our KalibroModule controller still reflects the old logic, as can be seen here.
We should adapt that action to the new logic.
After that we need to update our kalibro clients.
The text was updated successfully, but these errors were encountered:
This PR is related but does not solve the problem. It only prevents errors that can occur today, not breaking the API.
To actually fix this, we need to update the controller. That will break the KalibroProcessor's API. We've considered the change too small for a major release, so we will wait for when there are more significant changes accumulated.
In fact, maybe this is not an issue after all since our kalibro clients do not implement a request for the KalibroModule#module_results action. So, do you think we need to keep it? Or can we just remove it?
The only argument I have for keeping it is that other kalibro clients may need it.
Before, our business logic was that one
KalibroModule
could be related to manyModuleResults
.That logic has changed. Now, a
KalibroModule
only relates to oneModuleResult
.But our
KalibroModule
controller still reflects the old logic, as can be seen here.We should adapt that action to the new logic.
After that we need to update our kalibro clients.
The text was updated successfully, but these errors were encountered: