Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix action KalibroModule#module_results #171

Open
diegoamc opened this issue Feb 3, 2016 · 1 comment
Open

Fix action KalibroModule#module_results #171

diegoamc opened this issue Feb 3, 2016 · 1 comment

Comments

@diegoamc
Copy link
Contributor

diegoamc commented Feb 3, 2016

Before, our business logic was that one KalibroModule could be related to many ModuleResults.
That logic has changed. Now, a KalibroModule only relates to one ModuleResult.

But our KalibroModule controller still reflects the old logic, as can be seen here.

We should adapt that action to the new logic.
After that we need to update our kalibro clients.

@diegoamc diegoamc added the bug label Feb 3, 2016
@diegoamc
Copy link
Contributor Author

diegoamc commented Apr 8, 2016

This PR is related but does not solve the problem. It only prevents errors that can occur today, not breaking the API.

To actually fix this, we need to update the controller. That will break the KalibroProcessor's API. We've considered the change too small for a major release, so we will wait for when there are more significant changes accumulated.

In fact, maybe this is not an issue after all since our kalibro clients do not implement a request for the KalibroModule#module_results action. So, do you think we need to keep it? Or can we just remove it?

The only argument I have for keeping it is that other kalibro clients may need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant