-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added suggestions from check-manifest -v
are still ignored
#169
Comments
I only get this, when the |
@petschki thanks for the suggestion, but these files are committed and pushed to the repo on |
Thing is, MANIFEST.in is a setuptools feature, but you're not using setuptools, you're using sphinx-theme-builder. I'm not familiar with sphinx-theme-builder and don't know to make it include additional files in the sdist. I should make check-manifest produce a warning when pyproject.toml has a build-backend that is not setuptools, explaining that check-manifest's suggestions may be useless in this case. |
@mgedmin thanks for the information. That would be a very helpful warning. I'll try changing the build-system to setuptools, and see whether that includes these two files in the sdist. FYI, sphinx-theme-builder makes it easier to design themes for Sphinx through JavaScript tooling, using webpack to compile theme static assets. It is used to create PyData Sphinx Theme and Sphinx Book Theme. I copy-pasted from the project's |
Thanks for your help. For future reference, changing my [build-system]
- requires = ["sphinx-theme-builder >= 0.2.0a14"]
- build-backend = "sphinx_theme_builder"
+ requires = ["setuptools >= 69.5"]
+ build-backend = "setuptools.build_meta" @mgedmin I closed this issue because I was able to resolve my issue, but then realized you might want to add that warning still, so I'm reopening it. |
I ran
check-manifest -v
. It provided a helpful suggestion to add two rules toMANIFEST.in
, and I added those rules. When I runcheck-manifest -v
a second time, I still get the same suggestion.If I change both
include
rules toexclude
rules, then I get no suggestions. But I want to include them in the sdist, not exclude them.Could it be that the leading period or dot
.
causes the problem?The source repo to clone and reproduce the issue is https://github.com/plone/plone-sphinx-theme.
The text was updated successfully, but these errors were encountered: