Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use "+" character in query parameters #138

Open
gbarbon opened this issue Jul 30, 2021 · 0 comments
Open

Unable to use "+" character in query parameters #138

gbarbon opened this issue Jul 30, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@gbarbon
Copy link

gbarbon commented Jul 30, 2021

The feature or bug you are proposing

The + character is removed when parameters are parsed if the params are not URL encoded. E.g. using an "email" parameter with [email protected] value (in a GET) returns an empty array, instead of returning the array with the corresponding user.

The description of the bug or the rationale of your proposal

More precisely, the + character is substituted by fastify when parsing the query params, since the + char in a query parameters correspond to the whitespace character (see here for further info).

The expected result for your bug

The plugin should encode the URL, in such a way to avoid loosing special characters when they reach fastify.

However, we're not 100% sure that the plugin should perform the encoding automatically. Please also note that this feature might be breaking if someone is inserting the + char in the query parameter in order to insert a whitespace on purpose.

@gbarbon gbarbon added the bug Something isn't working label Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant