Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom system-wide TLS options #85

Open
fredmaggiowski opened this issue Mar 3, 2021 · 2 comments
Open

Support custom system-wide TLS options #85

fredmaggiowski opened this issue Mar 3, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@fredmaggiowski
Copy link
Member

The feauture or bug you are proposing

Since #84 serviceBuilder support custom tls options; it would be a good feature to be able to configure the library for system-wide TLS configurations

The description of the bug or the rationale of your proposal

The use case we'd like to address is providing the user with the ability to configure their services with custom TLS certificates for all serviceProxies that are created; we figured that providing environment variables with file paths (that should be mounted as files, e.g k8s configmaps/secrets) would be a good solution; if these variables are provided the library will read them at boot and provide all serviceBuilder invocation with the proper tls options.

Note: If a serviceBuilder provides specific tls options they should override the system wide

@davidebianchi
Copy link
Member

davidebianchi commented Mar 3, 2021

System wide certificates could be added without changes in lib, using node env variable NODE_EXTRA_CA_CERTS?

@fredmaggiowski
Copy link
Member Author

fredmaggiowski commented Mar 3, 2021

NODE_EXTRA_CA_CERTS works for Certification Authories certificates is there an equivalent for client private key and certificate? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants