Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review icons DevX and building process #610

Open
epessina opened this issue Sep 17, 2024 · 0 comments
Open

Review icons DevX and building process #610

epessina opened this issue Sep 17, 2024 · 0 comments
Labels
enhancement New feature or request Icon component Icon component and hooks related activities

Comments

@epessina
Copy link
Contributor

Following #477, we started shipping icon files in our package.

To avoid coupling the build of the components with the build of the icons, the DS components still use icons from react-icons. However, using our icons internally could help validate the distribution and the icons building process, without any size increment in the final bundle. We should substitute the icons imported from react-icons with the ones imported from our package.

Moreover, we should review when the building of the icons happens, since now it is executed in a specific script run in CI only on tags. If the icons become necessary for the development, we should include the script in each build, leveraging caching and file changes to avoid overworking the runners.

In this context, we should also consider pushing the icons on GitHub, even if the size of the package could significantly slow down clones and pulls.

@epessina epessina added enhancement New feature or request Icon component Icon component and hooks related activities labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Icon component Icon component and hooks related activities
Projects
None yet
Development

No branches or pull requests

1 participant