You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following #477, we started shipping icon files in our package.
To avoid coupling the build of the components with the build of the icons, the DS components still use icons from react-icons. However, using our icons internally could help validate the distribution and the icons building process, without any size increment in the final bundle. We should substitute the icons imported from react-icons with the ones imported from our package.
Moreover, we should review when the building of the icons happens, since now it is executed in a specific script run in CI only on tags. If the icons become necessary for the development, we should include the script in each build, leveraging caching and file changes to avoid overworking the runners.
In this context, we should also consider pushing the icons on GitHub, even if the size of the package could significantly slow down clones and pulls.
The text was updated successfully, but these errors were encountered:
Following #477, we started shipping icon files in our package.
To avoid coupling the build of the components with the build of the icons, the DS components still use icons from
react-icons
. However, using our icons internally could help validate the distribution and the icons building process, without any size increment in the final bundle. We should substitute the icons imported fromreact-icons
with the ones imported from our package.Moreover, we should review when the building of the icons happens, since now it is executed in a specific script run in CI only on tags. If the icons become necessary for the development, we should include the script in each build, leveraging caching and file changes to avoid overworking the runners.
In this context, we should also consider pushing the icons on GitHub, even if the size of the package could significantly slow down clones and pulls.
The text was updated successfully, but these errors were encountered: