Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Input] Correct the default icon size in input component #747

Open
nicmell opened this issue Dec 6, 2024 · 0 comments
Open

[Input] Correct the default icon size in input component #747

nicmell opened this issue Dec 6, 2024 · 0 comments

Comments

@nicmell
Copy link
Contributor

nicmell commented Dec 6, 2024

The default icon size in the input should be 16px, it's instead 12px.

Screenshot 2024-12-06 at 10 57 05

The problem is that the icon in the Search component (that inherits from Input) is 12px, and the icon size is not configurable.

Porposed solution:

Allow to pass a ReactElement to the iconBefore and iconAfter prop, allowing to specify the size and the color for the icon.

-<Input iconBefore={PiMagnifyingGlass} />
+<Input iconBefore={<Icon component={PiMagnifyingGlass} size={12}/>} />
@nicmell nicmell changed the title [Inut] Correct the default icon size in input component [Input] Correct the default icon size in input component Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant