Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Tree #67

Open
michaeljb opened this issue Sep 20, 2023 · 2 comments
Open

Action Tree #67

michaeljb opened this issue Sep 20, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@michaeljb
Copy link
Owner

michaeljb commented Sep 20, 2023

  • visualize all actions in a tree, like git commits
    • actions will need a new method to return a compact string for the tree
      • might be beneficial to change how broken actions are handled, so the action JSON knows its broken and it can be marked as such in the tree visualization
    • actions on various branch depth are "indented" to show they are branches
  • undo actions spins off a branch; undo and redo actions are hidden from the tree visualization
  • action tree page will have a selection toolbar
  • when in new mode, actions still validated by server (will need 'branch' param passed in so server knows which branch to validate, or maybe just param of last action to process) and added to actions list, but users will only see their own such branches
    • from normal mode, can select some premoved actions to "graft" them on to the current mainline branch and apply them now
      • option to hide grafted actions from the tree view
  • branch tracking?
    • each action has a branch field now? hopefully something more lightweight can be found
    • each action's parent and children can (should?) be computable
      • messages will need special handling

Benefits

  • will help with implementation of premoves
  • make undone actions discoverable/reviewable again--useful for debugging, and seeing paths explored by players
  • if an action is broken, but a lot of actions have been taken after it, can go back in time to that point, fix the broken action, and then graft on all the actions that followed
  • makes going back to change one small thing a turn more feasible--don't need to manually repeat all the actions since then, just graft them
@michaeljb michaeljb added the enhancement New feature or request label Sep 20, 2023
@michaeljb michaeljb self-assigned this Sep 25, 2023
@michaeljb
Copy link
Owner Author

michaeljb commented Sep 25, 2023

see branch action-tree

@michaeljb
Copy link
Owner Author

when an action has multiple children, UI to look at history down different paths?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant