Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header bar icon inconsistency (use symbolic icons) #28

Open
keeferrourke opened this issue Mar 2, 2017 · 1 comment
Open

Header bar icon inconsistency (use symbolic icons) #28

keeferrourke opened this issue Mar 2, 2017 · 1 comment

Comments

@keeferrourke
Copy link

For the GUI to have a consistent look across different icon themes, you should stick with either the symbolic icon set (as is recommended for GNOME applications) or the regular icon set.

In header-bar.py for instance, it seems that you're using (perhaps unintentionally) a mix of symbolic and regular icons.

I would recommend changing the header-bar to use only symbolic icons. Problematic lines include:

 49        document_open_image = Gtk.Image.new_from_icon_name("document-open", Gtk.IconSize.LARGE_TOOLBAR)`
139        document_properties_image = Gtk.Image.new_from_icon_name("open-menu", Gtk.IconSize.LARGE_TOOLBAR)`

Simply append -symbolic to each icon name listed above to resolve the issue.

@ghost
Copy link

ghost commented Aug 24, 2017

Cool it is fixed. And it should be closed ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant