-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract ManagedChannel Creation #195
base: master
Are you sure you want to change the base?
Abstract ManagedChannel Creation #195
Conversation
Hello; thanks for using microBean Helm. I like the general idea here; since what you want to do is not prohibited currently, I'd like to let this sit for a bit so I can chew on it. This project is slightly unique in that one of my design goals/constraints is to expose as tiny an API surface area as possible, as it's just me on nights and weekends. Perhaps what you want to do is best served by simply accepting something like a |
@ljnelson Totally understood! I was trying to keep it to one component but the dependency wiring into Take your time and let me know what you decide! Thanks for your hard work! |
I'm going to start by adding the ability to take in a |
…g spirit of #195. Signed-off-by: Laird Nelson <[email protected]>
@lewisheadden I have deployed |
While using this project, I found myself wanting to customize the
ManagedChannel
that was created. While I saw there was an option to overridebuildChannel
, I thought it might be nicer to provide that as a dependency toTiller
instead.As such, I created a
ManagedChannelFactory
interface which is used to create aManagedChannel
from aLocalPortForward
. I also provide the default implementation (DefaultManagedChannelFactory
) that migrates existing logic from the currentbuildChannel
method. It also allows the provision of aManagedChannelConfigurer
which is passed theManagedChannelBuilder
and is able to manipulate it before it is finally built.This allows users to do the following if they simply want to configure settings on the
ManagedChannel
instead of having to subclassTiller
.Let me know if I've not explained anything well, or if you have any concerns or changes you'd like.