Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binary parser unsafely allocates memory. #28

Open
groob opened this issue Apr 25, 2020 · 3 comments
Open

binary parser unsafely allocates memory. #28

groob opened this issue Apr 25, 2020 · 3 comments
Labels
bug help wanted

Comments

@groob
Copy link
Member

groob commented Apr 25, 2020

The binary plist tries to allocate a slice of arbitrary size and if it fails it tries to recover. But that doesn't actually work.

Setting 4<<20 (4 * 1024 * 1024) as an arbitrary limit until the binary parser is updated with better logic.
@groob groob changed the title OOM crash on some systems binary parser unsafely allocates memory. Apr 25, 2020
groob added a commit that referenced this issue Apr 25, 2020
@groob
Set size limit when allocating binary offsets.
2f574f4 
Fixes tests and potential real life panics, but is not ideal.
This is a temporary solution.

For #28
@groob groob mentioned this issue Apr 25, 2020
Merged
groob added a commit that referenced this issue Apr 25, 2020
@groob
Set size limit when allocating binary offsets. (#29)
526b8c3 
Fixes tests and potential real life panics, but is not ideal.
This is a temporary solution.

For #28
@AlexanderMatveev
Copy link

Can't parse Apple MDM signup plists because of this issue.
Getting plist: offset size larger than expected 4194304

@jessepeterson
Copy link
Member

@AlexanderMatveev sorry for the late reply! is there any way you can share a problematic plist file that we could take a look at?

@AlexanderMatveev
Copy link

AlexanderMatveev commented Jan 24, 2025 •
edited
Loading

@AlexanderMatveev sorry for the late reply! is there any way you can share a problematic plist file that we could take a look at?

@jessepeterson Unfortunately no, sorry 😔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jessepeterson @AlexanderMatveev @groob