Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reducing default profiling duration to 30 seconds than 2 minutes #164

Open
xiaomi7732 opened this issue Mar 25, 2022 · 2 comments
Milestone

Comments

@xiaomi7732
Copy link
Member

Reason:

  • If a request is as slow as 2 minutes, there is probably no need of profiler to find out where the issue is;
  • Smaller package is lightweight, easier to analysis, also less noise;
  • Less network traffic, faster upload;
@xiaomi7732 xiaomi7732 added this to the vNext milestone Apr 27, 2022
@xiaomi7732
Copy link
Member Author

Let's give it a shoot and see.

@xiaomi7732 xiaomi7732 reopened this Apr 27, 2022
@xiaomi7732 xiaomi7732 modified the milestones: 2.5.0-beta1, vNext + 2 May 23, 2022
@xiaomi7732 xiaomi7732 modified the milestones: 2.5.0, vNext + 1 Nov 15, 2022
@xiaomi7732 xiaomi7732 modified the milestones: vNext, vNext + 1 Mar 5, 2024
@xiaomi7732 xiaomi7732 modified the milestones: vNext, vNext + 1 Aug 16, 2024
@xiaomi7732
Copy link
Member Author

The story becomes complex when there's local settings and then there's remote settings in the mix. A bit design is needed.

@xiaomi7732 xiaomi7732 modified the milestones: vNext, vNext + 1 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant