Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install/build process should check and assert the requirements (e.g. clang compiler versions) #34

Open
bmerkle opened this issue Oct 19, 2024 · 6 comments · May be fixed by #38
Open

Install/build process should check and assert the requirements (e.g. clang compiler versions) #34

bmerkle opened this issue Oct 19, 2024 · 6 comments · May be fixed by #38

Comments

@bmerkle
Copy link

bmerkle commented Oct 19, 2024

The readme states some requirements about python, cmake and clang version.

Currently the install/build process does not check if the clang version requirement is satisfied and ubuntu e.g. come with a clang version 14.
This can also cause problems, e.g see bug report #30

It would be cool if the install/build process checks the requirements and stops the build process with an error it the version is not satisfied.
@bmerkle bmerkle mentioned this issue Oct 19, 2024
Closed
bmerkle added a commit to bmerkle/BitNet that referenced this issue Oct 19, 2024
@bmerkle
check for build requirements and abort build process if not satisied
f30c1de 
- python>=3.9
- cmake>=3.22
- clang>=18 on windows use the msvc-clang (>=17)

fix microsoft#34
@bmerkle bmerkle linked a pull request Oct 19, 2024 that will close this issue
Open
@algorise
Copy link

Header file seems to be missing in the repo. Getting the following error on clang:
Cannot find source file:
../../../../include/bitnet-lut-kernels.h

@edsonke
Copy link

edsonke commented Oct 21, 2024

@algorise
It looks like you need to run setup_env.py at least one time.
The header file is automatically generated after running the script with the instruction in README.md

@bmerkle
Copy link
Author

bmerkle commented Oct 21, 2024

@algorise
It looks like you need to run setup_env.py at least one time.
The header file is automatically generated after running the script with the instruction in README.md

It is a best practice to not include generated files in versioncontrol so i think the behaviour is ok. Running setup once should generate all the necessary files and configuration

@bmerkle bmerkle mentioned this issue Oct 22, 2024
Closed
@eddieoz
Copy link

eddieoz commented Oct 23, 2024

In my case, the bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)" installed clang-18, but didn't replace the clang-14 on my rpi5 debian.

I checked both versions were on /usr/bin, then I uninstalled clang and symlinked the all clang*18 to clang (without -18)

I wrote about the process to make it work:
https://www.eddieoz.com/building-bitnet-on-raspberry-pi-5-arm64-2/

@bmerkle
Copy link
Author

bmerkle commented Oct 23, 2024

instead of ln -s manually I would use: update-alternatives

sudo update-alternatives --config clang

@eddieoz
Copy link

eddieoz commented Oct 24, 2024

sudo update-alternatives --config clang

Thank you! I updated my post :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check for build requirements and abort build process if not satisfied bmerkle/BitNet
4 participants
@bmerkle @eddieoz @edsonke @algorise