New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop SECP256K1 support #6592

Closed

maxtropets opened this issue Oct 28, 2024 · 4 comments · Fixed by #6602

Assignees

Labels

mariner

Collaborator

maxtropets commented Oct 28, 2024

#6588 (comment)

Collaborator Author

maxtropets commented Oct 28, 2024 •

edited

Loading

@achamayou says
#6588 (comment)

Let's prove, drop support and close if that's the case, investigate otherwise

Member

achamayou commented Oct 29, 2024

Not present in https://github.com/microsoft/SymCrypt/blob/907622c6658877014ea3fea336e2efa407864fdc/lib/ec_internal_curves.c#L583
nor in https://github.com/microsoft/SymCrypt/blob/907622c6658877014ea3fea336e2efa407864fdc/unittest/lib/openssl_implementations.cpp#L1108

Probably good to ask to confirm, but seems very likely it's not supported.

Member

achamayou commented Oct 29, 2024

It's definitely not in the list of supported curves: https://github.com/microsoft/SymCrypt/blob/main/inc/symcrypt.h#L7463

Member

achamayou commented Oct 29, 2024

I think this ticket turns into "Drop SECP256K1 support in CCF", since:

we don't have an approved crypto provider that implements it on Azure Linux
we are no aware of any usage

maxtropets changed the title ~~Support SECP256K1 on Azure Linux~~ Drop SECP256K1 support

maxtropets mentioned this issue

Remove secp256k as unsupported by symcrypt on Mariner #6602

Merged

maxtropets self-assigned this

achamayou closed this as completed in #6602

maxtropets added the mariner label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment