Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xp_cmdshell being called when it might not be enabled #164

Open
gambit9009 opened this issue Apr 20, 2022 · 0 comments
Open

xp_cmdshell being called when it might not be enabled #164

gambit9009 opened this issue Apr 20, 2022 · 0 comments
Labels
enhancement wave 3 consider this issue for next wave of fixes

Comments

@gambit9009
Copy link
Contributor

xp_cmdshell is called in multiple places. Linux can't have this and is already Issue #35. But we should check all the places we call this to make sure xp_cmdshell is enabled and also make sure we really need to be calling xp_cmdshell to get the info.

Called multiple places in MSDagProcs.sql and FTS_Collector.sql

...see this code, line 2646 to be sure we do it everywhere.
-- Ensure xp_cmdshell is enabled before we try this
if (select value from sys.sysconfigures WHERE config=16390)=1 BEGIN

@gambit9009 gambit9009 added enhancement wave 3 consider this issue for next wave of fixes labels Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement wave 3 consider this issue for next wave of fixes
Projects
None yet
Development

No branches or pull requests

1 participant