Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create some system to warn both the DiagManager user and PSSDiag runner that the collection has possible higher resource usage #166

Open
gambit9009 opened this issue Apr 20, 2022 · 1 comment
Labels
enhancement postpone might be a bug or enhancement that will take a larger amount of engineering effort with lower ROI.

Comments

@gambit9009
Copy link
Contributor

gambit9009 commented Apr 20, 2022

There's no great 100% answer here. Users can select "Detailed" then strip off checks to where it wouldn't be as likely to cause an issue. They could select "General" but then manually add a bunch of collectors, traces, xevents, etc.

On some systems a heavier load, larger queries, etc. could make PSSDiag/SQLDiag use more recourses (large memory grants/CPU usage/Writing to disk) to collect data possibly regardless of some of the collectors.

We can't predict the load on the system at the time PSSDiag is running, but possibly we could just warn based on certain collectors picked. ????
Possibly warn if redundant collectors are picked. (dont know if this still happens but long ago some users might pick all the ways to get query plans and we'd get the same query plan captured many times)

Possibly add a node to the XML that just has better readable for human eyes lines about what exactly is being collected. Or even if not exact, a summary. "Detailed was chosen. Collecting 32 xevents. Collecting 3 custom collectors." etc

Adding this as a possible future enhancement but this would take some work.

@gambit9009 gambit9009 added enhancement postpone might be a bug or enhancement that will take a larger amount of engineering effort with lower ROI. labels Apr 20, 2022
@gambit9009
Copy link
Contributor Author

Probably a dup for #117 but also related to, or could fix....
#165
#55
#85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement postpone might be a bug or enhancement that will take a larger amount of engineering effort with lower ROI.
Projects
None yet
Development

No branches or pull requests

1 participant