Skip to content
This repository has been archived by the owner on Apr 27, 2024. It is now read-only.

Holograms 230 - Spatial Mapping - surfaceObserver not observing in Chapters 1 & 2 #35

Closed
roelkok opened this issue Jan 14, 2017 · 3 comments
Assignees

Comments

@roelkok
Copy link

roelkok commented Jan 14, 2017

If I follow Chapter 1: Scanning and Chapter 2: Visualization the project doesn't show anything in my HoloLens. The problem seems that StartObserver doesn't get called in the SpatialMappingManager. So no data is acquired and nothing will be displayed.

In Chapter 3: Processing there will be visual output once the PlaySpaceManager has been updated, because it will enter scanning mode if not enough surfaces have been found.

@chriskurzeja
Copy link

Agreed. I managed to make the example work again by porting code from the Toolkit version of SpatialMappingManager. This fixes the issue with no mesh being shown in Chapter 1 and Chapter 2.

Specifically I added the autoStartObserver property and Start method back into the SpatialMappingManager address this issue according to the implementation in the Toolkit.

       [Tooltip("Determines if the surface observer should be automatically started.")]
        public bool autoStartObserver = true;
        // Use for initialization.
        private void Start()
        {
            if (autoStartObserver)
            {
                StartObserver();
            }
        }

Hopefully this is an easy fix to actually apply.

@angelaHillier
Copy link
Contributor

Thanks for reporting this issue! I'm looking into it now and will be applying the fix shortly :)

@angelaHillier angelaHillier self-assigned this Jan 25, 2017
angelaHillier added a commit that referenced this issue Jan 26, 2017
Adds the Start() method back to SpatialMappingManager, which was
accidentally removed during the last update. This method is repsonsible
for starting the SurfaceObserver.
Also fixed: the RecalculateNormals was no longer present in
SpatialMappingObserver.cs. This call is required when using shaders
(like 'BlueLinesOnWalls') that rely on surface mesh normals being
correct.
@angelaHillier
Copy link
Contributor

OK, should be fixed now :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants