From e45e715c11c3cfba60c961e1f069707f47e5d01b Mon Sep 17 00:00:00 2001 From: James Lamb Date: Thu, 6 Feb 2025 19:57:10 -0600 Subject: [PATCH 1/4] [ci] fix valgrind workflow --- .github/workflows/r_valgrind.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/r_valgrind.yml b/.github/workflows/r_valgrind.yml index 961fe20942cb..caeecbc31f86 100644 --- a/.github/workflows/r_valgrind.yml +++ b/.github/workflows/r_valgrind.yml @@ -32,6 +32,7 @@ jobs: ref: "refs/pull/${{ github.event.client_payload.pr_number }}/merge" - name: Send init status if: ${{ always() }} + shell: bash run: | $GITHUB_WORKSPACE/.ci/set-commit-status.sh \ "${{ github.workflow }}" \ From 5072c3a01ec636738eb31911d0a1127e7d86e683 Mon Sep 17 00:00:00 2001 From: James Lamb Date: Thu, 6 Feb 2025 20:09:17 -0600 Subject: [PATCH 2/4] try without += --- .github/workflows/r_valgrind.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/r_valgrind.yml b/.github/workflows/r_valgrind.yml index caeecbc31f86..c8735b1a935d 100644 --- a/.github/workflows/r_valgrind.yml +++ b/.github/workflows/r_valgrind.yml @@ -39,7 +39,7 @@ jobs: "pending" \ "${{ github.event.client_payload.pr_sha }}" comment="Workflow **${{ github.workflow }}** has been triggered! 🚀\r\n" - comment+="${GITHUB_SERVER_URL}/microsoft/LightGBM/actions/runs/${GITHUB_RUN_ID}" + comment="${comment} ${GITHUB_SERVER_URL}/microsoft/LightGBM/actions/runs/${GITHUB_RUN_ID}" $GITHUB_WORKSPACE/.ci/append-comment.sh \ "${{ github.event.client_payload.comment_number }}" \ "${comment}" From 0559e17c961f9f66697df10e8b132f6e2da6ab0d Mon Sep 17 00:00:00 2001 From: James Lamb Date: Thu, 6 Feb 2025 20:16:54 -0600 Subject: [PATCH 3/4] one more += --- .github/workflows/optional_checks.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/optional_checks.yml b/.github/workflows/optional_checks.yml index 7c26d97bdeab..2454470408b0 100644 --- a/.github/workflows/optional_checks.yml +++ b/.github/workflows/optional_checks.yml @@ -16,6 +16,7 @@ jobs: fetch-depth: 5 submodules: false - name: Check that all tests succeeded + shell: bash run: | workflows=( "R valgrind tests;r-valgrind" @@ -23,7 +24,7 @@ jobs: for i in "${workflows[@]}"; do workflow_name=${i%;*} comment="The last reported status from workflow \"$workflow_name\" is failure." - comment+=" Commit fixes and rerun the workflow." + comment="${comment} Commit fixes and rerun the workflow." trigger_phrase=${i#*;} python \ "$GITHUB_WORKSPACE/.ci/get-workflow-status.py" \ From 060ee72f3e38a269389648a9fe6a013f3527737a Mon Sep 17 00:00:00 2001 From: James Lamb Date: Sun, 9 Feb 2025 16:18:17 -0600 Subject: [PATCH 4/4] Update .github/workflows/r_valgrind.yml Co-authored-by: Nikita Titov --- .github/workflows/r_valgrind.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/r_valgrind.yml b/.github/workflows/r_valgrind.yml index c8735b1a935d..6fda46fdfbcd 100644 --- a/.github/workflows/r_valgrind.yml +++ b/.github/workflows/r_valgrind.yml @@ -39,7 +39,7 @@ jobs: "pending" \ "${{ github.event.client_payload.pr_sha }}" comment="Workflow **${{ github.workflow }}** has been triggered! 🚀\r\n" - comment="${comment} ${GITHUB_SERVER_URL}/microsoft/LightGBM/actions/runs/${GITHUB_RUN_ID}" + comment="${comment}${GITHUB_SERVER_URL}/microsoft/LightGBM/actions/runs/${GITHUB_RUN_ID}" $GITHUB_WORKSPACE/.ci/append-comment.sh \ "${{ github.event.client_payload.comment_number }}" \ "${comment}"