-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]Send MIDI message to non-existense MIDI 1.0 device cable index port #447
Comments
Thanks. this is a known limitation in this release: all messages to/from WinMM use Group 0, which is going to map to that first port on a MIDI 1 device. Duplicate of #418 |
@Psychlist1972 |
Oh got it. Thanks. I was reading another bug right before this and thought it was the same thing. Our approach with the MIDI 2.0 driver with a MIDI 2.0 device is to send everything and the device drops messages when there's no existing group. Looks like the same logic is being used here @AmeNote-Michael , but that won't work. Instead, the driver needs to drop the message for the MIDI 1.0 device. Changing to a driver bug. |
@Psychlist1972 we need to discuss this. It would be a special data handling in the case of USB MIDI 1.0. In case of USB MIDI 2.0 the GTB and more importantly the Function Block information is unknown to the driver and thus the data-stream is just passed through in both directions - there is currently no handling for filtering data in the driver. Should this filtering occur in driver? And then I would argue that there would need to be some kind of mechanism to handle for adapting filter in USB MIDI 2.0 as well. |
MIDI 1.0 only. No changes to the MIDI 2.0 device behavior. This would only be at the point where you actually go to send messages to a specific cable #. At that point, you're doing translation, and you're having to read the message to translate group->cable anyway. |
@Psychlist197 this issue is resolved in PR#468 |
Describe the bug
When sending MIDI message to MIDI 1.0 device, Host PC sends non-existent cable index.
To Reproduce
Load the attached firmware to the ProtoZOA.
This firmware has worked as MIDI 1.0 device, and this has 4 MIDI input/output as below.
Make sure the USB MIDI 2.0 driver (UsbMidi2.sys) is loaded.
Open midi.exe and send the enclosed midi message file which sends note on message to all GTBs.
Check the USB packet which outputs Host PC, and it shows Host PC sends all cable index even if the MIDI device has 4 ports.
Expected behavior
Host PC sends MIDI message to the exisiting MIDI port only.
Installer Name or Version
Desktop (please complete the following information):
Device information, if this is with an external MIDI device:
UUT_ZOA_104.zip
Application Information
'midi.exe' console app.
Additional context
When we use MIDI 1.0 driver(USBAUDIO.sys), this issue doesn't happen. Host PC only sends first 4 MIDI I/O port as below.
The text was updated successfully, but these errors were encountered: