Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale "Visual Studio Code Workspaces" search results #30488

Closed
anderspk opened this issue Dec 16, 2023 · 4 comments
Closed

Stale "Visual Studio Code Workspaces" search results #30488

anderspk opened this issue Dec 16, 2023 · 4 comments
Assignees
Labels
Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@anderspk
Copy link
Contributor

Microsoft PowerToys version

0.76.1

Installation method

PowerToys auto-update

Running as admin

No

Area(s) with issue?

PowerToys Run

Steps to reproduce

I've noticed an issue with PowerToys Run where it continues to display workspace entries for Visual Studio Code (VSCode) projects that no longer exist. This seems to be due to VSCode not cleaning up workspace entries in User/globalStorage after a project is deleted/moved, and PowerToys Run doesn't filter out these stale entries.

✔️ Expected Behavior

Non-existing workspaces should not be displayed in the search result.

❌ Actual Behavior

Non-existing workspaces are displayed.

Other Software

No response

@anderspk anderspk added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Dec 16, 2023
@Aaron-Junker Aaron-Junker added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label Dec 16, 2023
@htcfreek
Copy link
Collaborator

htcfreek commented Dec 19, 2023

@anderspk
I think you have asked in the other issue (#28769) if you can start working on this. Feel free to open a PR and contribute the fix/enhancement. Please let us know here if you do so.

@anderspk
Copy link
Contributor Author

I'm starting to work on it now, should be done today.

@htcfreek htcfreek added Status-In progress This issue or work-item is under development and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Dec 20, 2023
@jaimecbernardo jaimecbernardo added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Jan 17, 2024
@jaimecbernardo
Copy link
Collaborator

Hi, this has been worked on for the 0.78 development cycle. 😄
Please update PowerToys to the latest: https://github.com/microsoft/PowerToys/releases

@anderspk
Copy link
Contributor Author

anderspk commented Feb 3, 2024

I'm sorry to say that I coded + tested this on my Windows 10 pc, where it works, but on my Windows 11 work laptop, which I tried it on after installing the update, it doesn't 😢
Sorry about that.

The main cause of this "bug" is VSCode itself, though, and the way they don't clean up workspaces.

Maybe a better solution anyways would be to allow users to delete/filter results from Run with something like shift + delete on a result, and then it ends up on a list they can access from the PT Run menu. That would cover all the unwanted search-results issues across the board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

4 participants