New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A question about the order of number mark #11

Open

Richar-Du opened this issue Nov 29, 2023 · 0 comments

Richar-Du commented Nov 29, 2023

Thanks for your awesome work! I have a question about the order of the number mark: the mark allocation algorithm in the paper states that the areas are sorted in an ascending order so that smaller regions are considered before large regions. However, the code sorts them in a descending order:
https://github.com/microsoft/SoM/blob/45ed34228cbf11457f0a131e6b78c7c8eb8e8d53/task_adapter/semantic_sam/tasks/inference_semsam_m2m_auto.py#L40C23-L40C23
And the largest area is marked first:

Do I misunderstand it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment