Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it available for scala 2.12 #445

Open
daureg opened this issue Nov 26, 2018 · 9 comments
Open

Make it available for scala 2.12 #445

daureg opened this issue Nov 26, 2018 · 9 comments
Assignees

Comments

@daureg
Copy link

daureg commented Nov 26, 2018

I couldn't download it in my Scala project until I downgraded scala version 2.11.

I tried quickly to compile myself, but I'm not very proficient with scala yet. One thing I noticed is that log4j-api-scala version 2.8.1 is not available for scala 2.12.

@mhamilton723 mhamilton723 self-assigned this Nov 29, 2018
@mhamilton723
Copy link
Collaborator

Thanks for reaching out @daureg i will try to bump the scala version for you. Now that Spark also moved to 2.12 this is a good time.

@MikioSuematsu
Copy link

@nightscape
Copy link
Contributor

Same question here @mhamilton723
Can I help with a PR, or does this have to do with publishing?

@nightscape
Copy link
Contributor

I checked the build scripts a little.
It looks like they're not meant for cross-publishing and the Scala version is hard-coded here.
The defvar function mentions though that it won't override existing environment variables, so I'm wondering if all one has to do is that someone from the Azure team runs the build once with SCALA_FULL_VERSION=2.12.8 and deploys the results to the repos?

@nightscape
Copy link
Contributor

Ping @mhamilton723, anything one can help with wrt this issue?

@mhamilton723
Copy link
Collaborator

mhamilton723 commented Mar 12, 2019

Hey @nightscape thanks for you investigation. I am not the author of that build script and hope to refactor much of this build to use more idiomatic sbt publishing stuff. if you make a PR changing that scala full version ill publish a package for you that you can use.

It looks like Azure Databricks still uses 2.11 so i dont think a full bump should be made yet, it would have to be cross compiled which might not be a trivial thing given the state of our build. For the official releases I think it might be best to wait until the whole build system gets a bit tamer. (I plan on undertaking this in the next month or two). Thanks for your flexibility!

@nightscape
Copy link
Contributor

@mhamilton723 thanks for the response!
I was thinking about trying it locally, but getting into a custom build system probably takes me hours.
So I'll just wait until the build system is tamed 😉

@andrioni
Copy link

Hi @mhamilton723, it seems that you have revamped the whole build system, and it's indeed pretty nice to see a fairly standard build.sbt file now :)
Any plans to cross-build to Scala 2.12 now?

@nightscape
Copy link
Contributor

I gave it a shot here:
#726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants