Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README confusion #56

Open
pcolmer opened this issue Feb 27, 2019 · 0 comments
Open

README confusion #56

pcolmer opened this issue Feb 27, 2019 · 0 comments

Comments

@pcolmer
Copy link

pcolmer commented Feb 27, 2019

Step 5 under "Getting Started" says:

Make sure to change the name of the project in the DistroLauncher-Appx/DistroLauncher-Appx.vcxproj file to the name of your executable we picked in step 4. By default, the lines should look like:
<PropertyGroup Label="Globals">
  ...
  <ProjectName>mydistro</ProjectName>
</PropertyGroup>
So, if I wanted to instead call my distro "TheBestDistroEver", I'd change this to:
<PropertyGroup Label="Globals">
  ...
  <ProjectName>TheBestDistroEver</ProjectName>
</PropertyGroup>
Note: DO NOT change the ProjectName of the DistroLauncher/DistroLauncher.vcxproj from the value launcher. Doing so will break the build, as the DistroLauncher-Appx project is looking for the output of this project as launcher.exe.

Those above instructions (a) say to change ProjectName then (b) say not to change it.

Also, the file as provided in the git repo doesn't mention "launcher" in either TargetName or ProjectName, so it isn't clear what the warning refers to.

Under "Build and Test", the instructions say:

To compile the project, you can simply type build in the root of the project to use MSBuild to build the solution.

However, when I do that, I get this error:

C:\Users\phili\Documents\GitHub projects\WSL-DistroLauncher>build.bat
Microsoft (R) Build Engine version 15.9.21+g9802d43bc3 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1008: Only one project can be specified.
Switch: projects\WSL-DistroLauncher\\DistroLauncher.sln

For switch syntax, type "MSBuild /help"

Under "Building Project (Visual Studio)", the documentation says:

In order run your solution under the Visual Studio debugger, you will need to copy your install.tar.gz file into your output folder, for example: x64\Debug.

That isn't correct - it needs to be under the platform type, not the output folder, i.e. "x64".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant