Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons don't warn about Win10 not supported #1557

Open
dotMorten opened this issue Jun 4, 2024 · 16 comments
Open

Icons don't warn about Win10 not supported #1557

dotMorten opened this issue Jun 4, 2024 · 16 comments
Labels
app enhancement Requests for general app improvements bug Something isn't working help wanted Extra attention is needed

Comments

@dotMorten
Copy link

Which version of the app?

WinUI 3 Gallery

Description

On the Iconography page it's too easy to go pick an icon glyph and add it to your app, not realizing it won't work on Windows 10. For instance the following will render a square placeholder on Windows 10:

<FontIcon Glyph="&#xEBD3;" />

However this will render fine:

<FontIcon Glyph="&#xE896;" />

With so many users still on Win10, it needs to be made easier to avoid making such mistakes, since it can get caught too late in the dev process if the developers are using Win11 machines.

Screenshots

No indication that this isn't supported on Windows 10:
image
This one right next to it though is supported on Windows 10:
image

Windows version

Windows 10 22H2 (19045)

Additional context

No response

@dotMorten dotMorten added bug Something isn't working needs-triage labels Jun 4, 2024
@marcelwgn
Copy link
Contributor

Thats a good point, would you expect there just to be a "Windows 10" disclaimer or also depending on the Windows build when it was available?

@niels9001
Copy link
Contributor

image

It's called out in the Expander.

But I agree, it doesn't jump out.

Maybe we could add an InfoBar at the top calling this out and warning folks that some icons might not render at all and testing is required?

@dotMorten
Copy link
Author

dotMorten commented Jun 6, 2024

That message isn’t helpful. Many of the icons do work on Win10 but not all. I’d like to see the warning in the icon detail when you select an icon that isn’t available in win10

@Jay-o-Way
Copy link
Contributor

Interesting. I wasn't aware some icons wouldn't be available in the MDL2 font. I wonder how many of them are missing. In my opinion, I think the code area (for the specific icon)would be the most appropriate place.

Screenshot_20240607-001253~2.png

@dotMorten
Copy link
Author

If they are on this page they are supported: https://learn.microsoft.com/en-us/windows/apps/design/style/segoe-ui-symbol-font
If they are on this page, Windows 11 is required: https://learn.microsoft.com/en-us/windows/apps/design/style/segoe-fluent-icons-font

@Jay-o-Way
Copy link
Contributor

If they are on this page they are supported: https://learn.microsoft.com/en-us/windows/apps/design/style/segoe-ui-symbol-font
If they are on this page, Windows 11 is required: https://learn.microsoft.com/en-us/windows/apps/design/style/segoe-fluent-icons-font

Technically, it's not about the OS, but a matter if the Fluent font is installed. Important difference.

@dotMorten
Copy link
Author

As you said: Technically. In practice though it'll catch developers out.

@Jay-o-Way
Copy link
Contributor

Yes, there is a clear correlation between the two. But when the Fluent font is installed on Windows 10 (which is super easy) a message calling out the OS would be invalid. Just trying to keep it accurate.

@dotMorten
Copy link
Author

But when the Fluent font is installed on Windows 10 (which is super easy)

Define "super easy". You shouldn't be expecting your users to be doing this. If anything you should include it in your app, but it's still worth pointing out that there's something you need to do and be aware of if you want to use those symbols on Windows 10.

@Jay-o-Way
Copy link
Contributor

If I may suggest:

Important

This icon is not available in the MDL2 font, the default icon font on Windows 10, and thus may not be rendered.

@Jay-o-Way

This comment has been minimized.

@dotMorten
Copy link
Author

No you don’t just do that. You need to build an app installer that does this. That’s not “super easy”. Again apps shouldn’t require people to do this themselves just to use the app. And that still doesn’t change the fact that someone needs to know they need to ensure this font is available. If it’s not installed all you get is a place holder icon and a poor app experience

@Jay-o-Way
Copy link
Contributor

Wait. My comments were based on old ideas. Back when Project Reunion wasn't renamed yet, there was a font (file) that basically acted as MDL2v2. I once installed it and, because of the same internal name, Windows 10 picked it up as the System Icon font. But that's long ago and will not work nowadays. Apologies. 🙇🏻‍♂️

@karkarl karkarl added help wanted Extra attention is needed app enhancement Requests for general app improvements and removed needs-triage labels Jun 13, 2024
@HO-COOH
Copy link
Contributor

HO-COOH commented Oct 12, 2024

Like, what even is this?
Image

@Jay-o-Way
Copy link
Contributor

@HO-COOH to answer your question: Windows 10 default icon font is MDL2. This font has some less icons than the newer Fluent Icons font, which is default for Windows 11. So, as I said earlier, the app says these icons are available in the Fluent font, so technically there's no blame. It would be a courtesy to add a note, for developers building apps that can be run on Windows 10.

@HO-COOH
Copy link
Contributor

HO-COOH commented Nov 6, 2024

@HO-COOH to answer your question: Windows 10 default icon font is MDL2. This font has some less icons than the newer Fluent Icons font, which is default for Windows 11. So, as I said earlier, the app says these icons are available in the Fluent font, so technically there's no blame. It would be a courtesy to add a note, for developers building apps that can be run on Windows 10.

Definitely, this should have a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app enhancement Requests for general app improvements bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants