Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitView Page - Mismatch between source code and rendered example #1587

Open
fabianoriccardi opened this issue Jul 16, 2024 · 0 comments
Open

SplitView Page - Mismatch between source code and rendered example #1587

fabianoriccardi opened this issue Jul 16, 2024 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed sample enhancement Requests for new samples or changes to an existing page

Comments

@fabianoriccardi
Copy link

Which version of the app?

WinUI 3 Gallery

Description

The source code contains a Settings "tab" but the rendered content doesn't display it (see screenshot below).

Other than the obvious mismatch between rendered content and source code, IMHO, this similarity between SplitView and NavigationView may be confusing for a learner, so I think it should be deleted.

Here the source code:

         <StackPanel Orientation="Horizontal" Grid.Row="2" Margin="14,24,0,24" >
                <SymbolIcon Symbol="Setting" />
                <TextBlock Text="Settings" Margin="24,0,0,0" VerticalAlignment="Center"/>
            </StackPanel>

Screenshots

Imm

Windows version

Windows 10 22H2 (19045)

Additional context

No response
@fabianoriccardi fabianoriccardi added bug Something isn't working needs-triage labels Jul 16, 2024
@karkarl karkarl added sample enhancement Requests for new samples or changes to an existing page help wanted Extra attention is needed and removed needs-triage labels Jul 18, 2024
@Zakariathr22 Zakariathr22 mentioned this issue Aug 23, 2024
Merged
3 tasks
karkarl pushed a commit that referenced this issue Nov 13, 2024
@Zakariathr22
SplitView Sample -> fix the mismatch between rendered content and s…
5f46afa 
…ource code (#1617)

## Description
A simple update to resolve discrepancies between the rendered content
and the displayed source code, the only change is:
- Remove the code that does not match from the displayed source code
(SplitViewPage.xaml).

## Motivation and Context
- The similarity between SplitView and NavigationView might be confusing
for learners, so it would be best to remove it.
- fixes this issue:
#1587

## How Has This Been Tested?
**Manually Tested**

## Screenshots:

![image](https://github.com/user-attachments/assets/939c7f48-f94e-425a-b6d4-72a1c56e9242)

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed sample enhancement Requests for new samples or changes to an existing page
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabianoriccardi @karkarl