Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated Code for ADO PAT Generation #24

Open
Stuart-Wilcox opened this issue Apr 30, 2024 · 0 comments
Open

Duplicated Code for ADO PAT Generation #24

Stuart-Wilcox opened this issue Apr 30, 2024 · 0 comments

Comments

@Stuart-Wilcox
Copy link
Contributor

Describe the bug

The code for creating an ADO PAT appears to be duplicated between two places in different packages. This makes is confusing for new people to make contributions, and is also just a poor design.

To Reproduce
See packages/node-azureauth/src/pat.ts and packages/ado-npm-auth/src/azureauth/ado.ts

Expected behavior
One file should have most of this code and then it gets imported in other places

Screenshots
Example these types
image

Additional context
This likely happened as an oversight when we migrated the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant