Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SVG Icon Visibility in Dark Mode on GitHub Preview Pages #749

Open
Axeia opened this issue Sep 2, 2024 · 1 comment
Open

Improve SVG Icon Visibility in Dark Mode on GitHub Preview Pages #749

Axeia opened this issue Sep 2, 2024 · 1 comment

Comments

@Axeia
Copy link

Axeia commented Sep 2, 2024

On the following preview pages:

The icons are very hard to see when the OS is set to dark mode, which in turn makes GitHub render in dark mode. Here is an example of the ‘filled’ icons under Windows 11 (in Google Chrome) with Windows’ color mode set to ‘Dark’:
image

All SVGs have a hardcoded color value of #212121. Setting this to a color with better contrast would make the pages much more accessible for dark mode users.

Alternatively, using currentColor as the fill value might automatically use the font color of the page, ensuring suitable contrast in all situations, although I have not tested this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@Axeia and others