Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(react-tree): improve High Contrast on focus indicator #33779

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(react-tree): improve High Contrast on focus indicator #33779

wants to merge 1 commit into from

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Feb 5, 2025 •
edited
Loading

Previous Behavior

image

New Behavior

image

Related Issue(s)

@bsunderhus bsunderhus self-assigned this Feb 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library		 1.17 MB
293.049 kB		 1.17 MB
293.078 kB		 356 B
29 B
react-tree
FlatTree		 147.793 kB
42.393 kB		 148.149 kB
42.415 kB		 356 B
22 B
react-tree
PersonaFlatTree		 148.538 kB
42.536 kB		 148.894 kB
42.551 kB		 356 B
15 B
react-tree
PersonaTree		 144.749 kB
41.391 kB		 145.105 kB
41.408 kB		 356 B
17 B
react-tree
Tree		 144.01 kB
41.265 kB		 144.366 kB
41.287 kB		 356 B
22 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme		 69.638 kB
20.24 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 224.582 kB
64.913 kB
react-components
react-components: FluentProvider & webLightTheme		 44.473 kB
14.597 kB
react-portal-compat
PortalCompatProvider		 8.39 kB
2.64 kB
react-timepicker-compat
TimePicker		 108.551 kB
36.094 kB
🤖 This report was generated against ba032e4ec23540137c17d75e0a6a38d8da4e931c

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

Pull request demo site: URL

@bsunderhus bsunderhus marked this pull request as ready for review February 5, 2025 11:02
@bsunderhus bsunderhus requested a review from a team as a code owner February 5, 2025 11:02
@bsunderhus bsunderhus changed the title chore: improve High Contrast on focus indicator chore(react-tree): improve High Contrast on focus indicator Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@bsunderhus bsunderhus

Labels
Area: Accessibility Component: Tree
Projects
None yet
Milestone
February Project Cycle Q1 2025
Development

Successfully merging this pull request may close these issues.

[Bug]: Tree component is not built with High Contrast in mind.
2 participants
@bsunderhus @fabricteam