Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: 'connection_string' support for vector_store (cosmosdb) #1791

Open
3 tasks done
basitanees opened this issue Mar 6, 2025 · 0 comments
Open
3 tasks done
Labels
enhancement New feature or request

Comments

@basitanees
Copy link

basitanees commented Mar 6, 2025

Do you need to file an issue?

  • I have searched the existing issues and this feature is not already filed.
  • My model is hosted on OpenAI or Azure. If not, please look at the "model providers" issue and don't file a new one here.
  • I believe this is a legitimate feature request, not just a question. If this is a question, please use the Discussions area.

Is your feature request related to a problem? Please describe.

Hi, in graphrag 2.0, it seems that if we give a connection_string parameter for the Cosmosdb vector store config, it is ignored and not used by the CosmosdbVectoreStore. It is likely because, the vector store config class does not contain this parameter any more.

References:

class VectorStoreDefaults:

class VectorStoreConfig(BaseModel):

url=url, credential=DefaultAzureCredential()

Describe the solution you'd like

  1. We could include the connection_string parameter within the VectorStoreConfig class.
  2. Another solution is to store the access_key in the api_key parameter, and then call cosmos_client in (vector_stores/cosmosdb.py) like this:
access_key = kwargs.get("api_key")
if access_key:
  self._cosmos_client = CosmosClient(
                  url=url, credential=access_key
              )
else:
  self._cosmos_client = CosmosClient(
                  url=url, credential=DefaultAzureCredential()
              )

Additional context

No response

@basitanees basitanees added the enhancement New feature or request label Mar 6, 2025
@basitanees basitanees mentioned this issue Mar 6, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant