-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove exception and validation for user/password with AccessTokenCallback #2549
Conversation
…WithUserPassword. This logic may be too restrictive and may be removed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2549 +/- ##
============================================
+ Coverage 50.96% 50.99% +0.03%
Complexity 3912 3912
============================================
Files 147 147
Lines 33460 33456 -4
Branches 5608 5604 -4
============================================
+ Hits 17052 17060 +8
+ Misses 13999 13989 -10
+ Partials 2409 2407 -2 ☔ View full report in Codecov by Sentry. |
… case in PooledConnectionTest.java
@microsoft-github-policy-service agree company="Microsoft" |
src/test/java/com/microsoft/sqlserver/jdbc/fedauth/PooledConnectionTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of just stating what the code change is, update title to be more descriptive and add in comments if necessary. Also remove reference to "Feature-32573" here that is meaningless
The SQLServerConnection connectInternal() method throws the exception R_AccessTokenCallbackWithUserPassword. This logic may be too restrictive and has therefore been removed.